Remove unnecessary radius calculation in TFCoil class

[chris-ashe]

Description

This is a legacy issue and should be solved by #3748 . There was error checking in the output (should not be there...) that was missed in #3748 and so the $\cos\left(\frac{\pi}{N_{TF}}\right)$ has now been removed

Checklist

I confirm that I have completed the following checks:

• My changes follow the PROCESS style guide
• I have justified any large differences in the regression tests caused by this pull request in the comments.
• I have added new tests where appropriate for the changes I have made.
• If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
• If I have made documentation changes, I have checked they render correctly.
• I have added documentation for my change, if appropriate.

[timothy-nunn]

@mkovari you asked on the issue to be listed as a reviewer

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.19%. Comparing base (6d036d5) to head (5ebede1).

Files with missing lines	Patch %	Lines
process/models/tfcoil/base.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4090   +/-   ##
=======================================
  Coverage   47.18%   47.19%           
=======================================
  Files         138      138           
  Lines       29280    29275    -5     
=======================================
  Hits        13817    13817           
+ Misses      15463    15458    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[timothy-nunn]

As part of the PR can you also remove the outputting into the OUT.DAT.

If the dimensions are inconsistent, it should be done with logger.error not commenting/outputs to the MFile and OUTFile. No need to do anything if they are consistent.

[ym1906]

This is unnecessary and can be removed. As @timothy-nunn pointed out, the output has to be removed too.

[timothy-nunn]

Thanks @ym1906 for the review. I've removed the warning from the output and put it in the logger. Can you confirm that you're happy with this solution and, if so, approve it for me.

Cheers,
Tim

[ym1906]

Looks good to me.

[mkovari]

And are the dimensions consistent?
@timothy-nunn

[timothy-nunn]

And are the dimensions consistent? @timothy-nunn

@mkovari removing this calculation stops the warning message from being displayed, so yes we believe they are consistent.

[mkovari]

Are you saying that having removed the error checking you now don't see the error message?
Or are you saying that there was an error in the mathematics which has now been corrected?