Skip to content

Create plasma current class#4086

Draft
chris-ashe wants to merge 4 commits intomainfrom
create_plasma_current_class
Draft

Create plasma current class#4086
chris-ashe wants to merge 4 commits intomainfrom
create_plasma_current_class

Conversation

@chris-ashe
Copy link
Collaborator

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe added Physics Relating to the physics models Refactor labels Feb 8, 2026
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2026

Codecov Report

❌ Patch coverage is 75.43860% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.25%. Comparing base (4741c15) to head (248115d).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
process/models/physics/plasma_current.py 76.41% 25 Missing ⚠️
process/models/physics/physics.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4086      +/-   ##
==========================================
+ Coverage   46.88%   47.25%   +0.36%     
==========================================
  Files         136      139       +3     
  Lines       29253    29365     +112     
==========================================
+ Hits        13715    13875     +160     
+ Misses      15538    15490      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Updated test_physics.py to instantiate PlasmaCurrent for calculating plasma current and related methods.
- Replaced direct calls to calculate_plasma_current_peng and calculate_current_coefficient_hastie with PlasmaCurrent class methods.
- Modified test_stellarator.py to include PlasmaCurrent in the stellarator setup.
@chris-ashe chris-ashe force-pushed the create_plasma_current_class branch from 935e8f0 to 660cc7c Compare February 26, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Physics Relating to the physics models Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants