Merged
Conversation
Agent-Logs-Url: https://github.com/ujiro99/selection-command/sessions/4bc05081-338b-49d0-83d1-a596d74b1b76 Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix analytics event sending during e2e build
feat: e2eビルド時にanalyticsイベントの送信を無効化
Apr 2, 2026
ujiro99
approved these changes
Apr 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
=======================================
Coverage 25.66% 25.66%
=======================================
Files 309 309
Lines 31240 31240
Branches 1546 1547 +1
=======================================
Hits 8017 8017
Misses 23223 23223 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e2eビルド(
--mode e2e)時にGA(Google Analytics)へイベントが送信されてしまう問題を修正。変更点
analytics.tsのDISABLE_ANALYTICSフラグにisE2E条件を追加isE2Eはimport.meta.env.MODE === "e2e"で評価されるコンパイル時定数。yarn build:e2e(Vite--mode e2e)でビルドされた場合のみtrueとなる。