feat: add requireChildren option for route matching #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new `requireChildren` option to route definitions that controls whether a parent route can match when no children match. - Default is `true` (breaking change): parent routes require a child to match, enabling catch-all NotFound pages to work intuitively - Set to `false` to allow parent routes to match alone with outlet=null This change makes route matching more predictable and allows catch-all routes like `/*` to properly handle unmatched nested URLs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
requireChildrenoption to route definitions that controls whether a parent route can match when no children matchtrue(breaking change): parent routes now require at least one child to matchrequireChildren: falseallows parent routes to match alone withoutletasnullBehavior
requireChildrentrue(default)falsefalseTest plan
requireChildrenoption inmatchRoutes.test.tsrequireChildren: falsepnpm test:run)pnpm typecheck)🤖 Generated with Claude Code