Added platform-aware golden image logic#79
Open
caseycrogers wants to merge 5 commits intoueman:masterfrom
Open
Added platform-aware golden image logic#79caseycrogers wants to merge 5 commits intoueman:masterfrom
caseycrogers wants to merge 5 commits intoueman:masterfrom
Conversation
Contributor
Author
|
@ueman flagging for review! This is a super small change to just the golden image tests. |
Owner
|
This is great! Do you mind pulling in the On CI the golden image checks would have to be enabled on all platforms. Though this raises the question how am I supposed to generate those images if I don't have access to one of the other platforms? I believe it should be doable with a GitHub Workflow. |
Contributor
Author
|
@ueman I've updated this to pull from master and to remove a TODO regarding a bug in an older version of flutter! Let me know if you need anymore next steps from me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
There's a bug in
testWidgetsthat makes group level test skipping not work. The bug is fixed in Flutter version 2.1.0 (flutter/flutter#76174) but 2.1.0 isn't out on stable yet. We could release this PR now and clean it up a little when 2.1.0 is out (see todo note in PR) or we could wait until the bugfix is out, clean up the PR, and then merge.💡 Motivation and Context
Golden image tests would fail trivially on any platform but OSX. I'm working in Windows and wanted working golden tests for my PRs against this repo.
💚 How did you test it?
Ran the tests with spoofed platforms to verify skipping and image selection works as intended.
📝 Checklist
🔮 Next steps