Feat: Hide sensitive content in screenshot#380
Open
JakesMD wants to merge 5 commits intoueman:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
I added the ability to hide sensitive content in draw mode and in the screenshot itself.
Changes:
FeedbackRedactedwidget that blurs its child in draw mode and in the screenshot.FeedbackRedactionControllerto notifyFeedbackRedactedwidgets of changes to the redaction state.FeedbackController.redactionController.unredact()call toFeedbackController.hide().FeedbackWidgetto redact and unredact depending on the mode and whether a screenshot is being taken.💡 Motivation and Context
Helps devs comply with privacy regulations.
The option to detect for
SensitiveContentwidgets was explored, but it's practically impossible to accurately find out whether aSensitiveContentwidget is visible or even just partially obscured (see #378 (comment)).Fixes #378
💚 How did you test it?
FeedbackRedactedwidgetFeedbackControllerto check thatunredact()is called duringhide()FeedbackRedactionControllertests to check that it's notifying listeners.📝 Checklist