Refactor API to use strongly typed generics and push/pop style model#336
Draft
caseycrogers wants to merge 1 commit intoueman:masterfrom
Draft
Refactor API to use strongly typed generics and push/pop style model#336caseycrogers wants to merge 1 commit intoueman:masterfrom
caseycrogers wants to merge 1 commit intoueman:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
show) and an output object (passed into hide, returned from show) that enforces end to end type safetysimpleFeedbacksystem was moved to a static method (necessary to set the default type params)simpleFeedbacknow runs theonSubmitcallback before closing the feedback flowFeedbakcFormControllerthat exposes the screenshot and scroll controllershidethemselves💡 Motivation and Context
There are three core goals with this rewrite:
💚 How did you test it?
📝 Checklist
🔮 Next steps