fix(code-block): fix normalizer and insertBreak for syntax highlighting#4837
Open
ttillberg wants to merge 1 commit intoudecode:mainfrom
Open
fix(code-block): fix normalizer and insertBreak for syntax highlighting#4837ttillberg wants to merge 1 commit intoudecode:mainfrom
ttillberg wants to merge 1 commit intoudecode:mainfrom
Conversation
…structure use wrapNodes instead of setNodes in normalizer to properly wrap bare text children in code_line elements. reset decoration cache after insertBreak so new lines get syntax highlighting immediately. - normalizer: wrapNodes instead of setNodes for bare text in code_block - insertBreak: call resetCodeBlockDecorations after splitting fixes udecode#4520 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
🦋 Changeset detectedLatest commit: 76306d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
Thanks for the PR! Could you fix the test CI? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wrapNodesinstead ofsetNodesto properly wrap bare text children incode_lineelements.setNodeswas producing malformed nodes like{ text: "...", type: "code_line" }instead of proper{ type: "code_line", children: [{ text: "..." }] }structure.resetCodeBlockDecorationsafter splitting to bust the WeakMap cache and force re-highlighting on all lines.These two fixes together resolve the issue where only the first line of a code block gets syntax highlighting.
Fixes #4520
Related: #4399, #3407
Test plan