Skip to content

Conversation

@mbusch3
Copy link
Contributor

@mbusch3 mbusch3 commented Oct 20, 2025

This PR was initially started because I was trying to figure out the stupid "inconsistent scan results" bug. I started by cleaning up a LOT of old PHP that isn't used anymore and trying to make sure that consistent functions are called regardless of whether content is scanned from the full rescan or the quick checkup scan.

I've changed the .env variables to remove the lambda references and list the excluded rule Ids. The .env.example file is updated to reflect that.

The biggest change is that now Quiz Questions can be scanned, show up on the report (under the "Quiz" content type), and can be saved back to Canvas properly. That one wasn't really all that many lines of code all told, but was a pain to get working. The biggest change is that we are now saving an "parentLmsId" in the content_item metadata. The saving and updating functions now use that to create the proper URL (/courses/course_id/quizzes/QUIZ_ID/questions/question_id).

@dmols dmols self-requested a review October 24, 2025 11:49
Copy link
Contributor

@dmols dmols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended! I only have a few notes of potential changes we can add to make the experience a little better:

  • Unlike the changes made to other forms of content on a course, it seems changing anything inaccessible in a quiz puts it in a sort of 'draft' state. This means the faculty member needs to go back into the quiz and save the changes.
Screenshot 2025-10-24 at 7 51 31 AM

I would propose that we make that known somewhere in the form instructions (maybe as an additional info note based on if the form refers to quiz content?)

  • Less important than the one above, but if the accessibility issue involves a quiz question, clicking the arrow to go to the page will take the user to the main page of the quiz, not the quiz question that has the issue. Is it possible to redirect users to the quiz question instead of the main quiz? Not too annoying for small quizzes, but I could see this being a little annoying for big quizzes.

@mbusch3
Copy link
Contributor Author

mbusch3 commented Oct 29, 2025

I tried to figure out how to get the quiz to re-save as well, but couldn't get it. There is also NOT a quiz-question-specific link in Canvas. So to address your comment, I:

  • Added some helpful informational text when quiz questions were saved that lets the user know they still need to manually save the quiz.
  • Updated the link from quiz questions to go into the "questions tab" in the quiz's edit screen, which is as close as I could get to linking straight to the question.

@dmols dmols self-requested a review November 4, 2025 11:57
Copy link
Contributor

@dmols dmols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality is still good from last time, and I like the most recent additions! I think the only thing that needs addressing is the fact that images will flicker on this branch. It's strange that this is happening, seeing as the fix from this PR #1029 is in the target branch new-main-page-UX already. I've attempted to bring over some of the changes from that PR in hopes of fixing the issue, but it seems to just make the behavior more aggressive, even when there aren't problems compiling.

Once the flicker weirdness is addressed, I believe we can push this PR forward!

@dmols
Copy link
Contributor

dmols commented Dec 3, 2025

Update: Some of his image flicker changes may have been overwritten, since adding some of those changes make the images flicker more, for whatever reason. The current state of new-main-page-UX doesn't seem to have the changes he made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants