-
Notifications
You must be signed in to change notification settings - Fork 74
Adds Quiz Question saving and scanning. #1070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: new-main-page-UX
Are you sure you want to change the base?
Adds Quiz Question saving and scanning. #1070
Conversation
dmols
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as intended! I only have a few notes of potential changes we can add to make the experience a little better:
- Unlike the changes made to other forms of content on a course, it seems changing anything inaccessible in a quiz puts it in a sort of 'draft' state. This means the faculty member needs to go back into the quiz and save the changes.
I would propose that we make that known somewhere in the form instructions (maybe as an additional info note based on if the form refers to quiz content?)
- Less important than the one above, but if the accessibility issue involves a quiz question, clicking the arrow to go to the page will take the user to the main page of the quiz, not the quiz question that has the issue. Is it possible to redirect users to the quiz question instead of the main quiz? Not too annoying for small quizzes, but I could see this being a little annoying for big quizzes.
|
I tried to figure out how to get the quiz to re-save as well, but couldn't get it. There is also NOT a quiz-question-specific link in Canvas. So to address your comment, I:
|
dmols
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality is still good from last time, and I like the most recent additions! I think the only thing that needs addressing is the fact that images will flicker on this branch. It's strange that this is happening, seeing as the fix from this PR #1029 is in the target branch new-main-page-UX already. I've attempted to bring over some of the changes from that PR in hopes of fixing the issue, but it seems to just make the behavior more aggressive, even when there aren't problems compiling.
Once the flicker weirdness is addressed, I believe we can push this PR forward!
|
Update: Some of his image flicker changes may have been overwritten, since adding some of those changes make the images flicker more, for whatever reason. The current state of |
This PR was initially started because I was trying to figure out the stupid "inconsistent scan results" bug. I started by cleaning up a LOT of old PHP that isn't used anymore and trying to make sure that consistent functions are called regardless of whether content is scanned from the full rescan or the quick checkup scan.
I've changed the
.envvariables to remove the lambda references and list the excluded rule Ids. The.env.examplefile is updated to reflect that.The biggest change is that now Quiz Questions can be scanned, show up on the report (under the "Quiz" content type), and can be saved back to Canvas properly. That one wasn't really all that many lines of code all told, but was a pain to get working. The biggest change is that we are now saving an "parentLmsId" in the content_item metadata. The saving and updating functions now use that to create the proper URL (/courses/course_id/quizzes/QUIZ_ID/questions/question_id).