feat(solver): significantly improve solver performance #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perf(Solver): further improvements to solver
rohanku
requested changes
Nov 27, 2025
Contributor
rohanku
left a comment
rohanku
left a comment
There was a problem hiding this comment.
Left some basic comments, will need to take a more careful look at your unsafe code/null space logic.
rohanku
requested changes
Dec 10, 2025
rohanku
requested changes
Jan 4, 2026
rohanku
reviewed
Jan 4, 2026
| #[test] | ||
| fn big_num_stab_test() { | ||
| //make a graph laplacian for grid, want to see if QR = A | ||
| fn generate_bad_value() -> f64 { |
Contributor
There was a problem hiding this comment.
What does this actually test? Size 25 is pretty small.
rohanku
reviewed
Jan 4, 2026
Added installation instructions for SuiteSparse on macOS and Windows/Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.