[Feat] Configure global state at compile-time #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamed
force-pushed
the
config-global-state
branch
2 times, most recently
from
03e3302 to
75a5272
Compare
This patch adds preprocessor facilities to enable choosing between global state (SoftFloatv3 default) and adding a "state" parameter to all functions. This has been discussed already by John Hauser at: ucb-bar#5 This patch takes the position of enabling both options using a preprocessor macro named "SOFTFLOAT_USE_GLOBAL_STATE". If the macro is defined, then it uses global state as it does already. If the macro is undefined, then it adds a state parameter which is a struct defined in softfloat_types.h
mohamed
force-pushed
the
config-global-state
branch
from
75a5272 to
8ae3372
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds preprocessor facilities to enable choosing between
global state (SoftFloatv3 default) and adding a "state" parameter
to all functions. This has been discussed already by John Hauser
at: #5
This patch takes the position of enabling both options using a
preprocessor macro named "SOFTFLOAT_USE_GLOBAL_STATE". If the macro
is defined, then it uses global state as it does already. If the
macro is undefined, then it adds a state parameter which is a struct
defined in softfloat_types.h