Skip to content

Ensured TMPDIR can now be overriden and is always valid.#29

Closed
qflen wants to merge 6 commits intoubuntu:stablefrom
qflen:fix-tmpdir-override
Closed

Ensured TMPDIR can now be overriden and is always valid.#29
qflen wants to merge 6 commits intoubuntu:stablefrom
qflen:fix-tmpdir-override

Conversation

@qflen
Copy link
Copy Markdown
Contributor

@qflen qflen commented Jan 30, 2025

Summary

This improves TMPDIR handling by ensuring:

  • TMPDIR defaults to ~/Downloads/thunderbird.tmp only if it is unset or invalid.
  • /thunderbird.tmp is always appended to a valid directory

Why

Previously, TMPDIR was overridden without minding user preference.

Linked Issue

Fixes #3

sergio-costas
sergio-costas reviewed Jan 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sergio-costas sergio-costas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little nitpick.

Comment thread tmpdir Outdated
@qflen qflen requested a review from sergio-costas February 7, 2025 14:26
sergio-costas
sergio-costas approved these changes Feb 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sergio-costas sergio-costas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks perfect. Thanks!

@hellsworth
Copy link
Copy Markdown
Contributor

hellsworth commented Feb 7, 2025

lgtm too!

@seb128
Copy link
Copy Markdown
Contributor

seb128 commented Apr 15, 2025

Thanks for the working and sorry for the delay reviewing the change. Do we really still need that override?

We removed it from the firefox snap
https://bugzilla.mozilla.org/show_bug.cgi?id=1733750#c6
canonical/firefox-snap@250d24a72

the rational is

browser.download.improvements_to_download_panel to true, then files are downloaded to the default Downloads directory

Is thunderbird sharing that default? If so should we do the same as firefox and just remove that script?

@Hativ
Copy link
Copy Markdown

Hativ commented Aug 13, 2025

Please let's get rid of that stupid thunderbird.tmp directory in ~/Downloads..

@qflen
Copy link
Copy Markdown
Contributor Author

qflen commented Nov 4, 2025 •
edited
Loading

@seb128 I'm also coming back this after a while. I deleted the file entirely. Can you merge?

@nteodosio nteodosio self-requested a review November 11, 2025 10:11
@nteodosio nteodosio requested a review from seb128 November 11, 2025 10:11
@mitar
Copy link
Copy Markdown

mitar commented Jan 17, 2026

This would be great!

@nteodosio nteodosio changed the base branch from stable to beta January 26, 2026 09:26
@nteodosio nteodosio changed the base branch from beta to stable January 26, 2026 09:26
@nteodosio
Copy link
Copy Markdown
Contributor

nteodosio commented Jan 26, 2026

I cherry-picked to beta. After the usual phasing/testing will proceed to pull it into the other branches. Thanks!

@nteodosio
Copy link
Copy Markdown
Contributor

nteodosio commented Feb 2, 2026

This is now fully merged.

@nteodosio nteodosio closed this Feb 2, 2026
@qflen qflen mentioned this pull request Apr 22, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nteodosio nteodosio nteodosio approved these changes

@sergio-costas sergio-costas sergio-costas approved these changes

@seb128 seb128 Awaiting requested review from seb128

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow to override TMPDIR

7 participants

@qflen @hellsworth @seb128 @Hativ @mitar @nteodosio @sergio-costas