Open
Conversation
…ensitive platforms * Updated all sample projects except fastbuild since those include local installation into
kudaba
force-pushed
the
pr/remove_path_lower
branch
from
393fc93 to
aa65bce
Compare
Contributor
|
FWIW we've been running with a similar change to PathMakeStandard to remove casing in our local branch without issue for well over two years at this point. This would be nice to push into the official repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to #166 this change removes the lower-casing feature of makestandard path. I had been running with the feature disabled locally with no noticeable side effects. It has to be disabled on all non-windows platforms anyway.