Skip to content

feat: add implicit conversion on gitlabcollectionresponse<T>#1045

Merged
louis-z merged 3 commits intomainfrom
feat-add-explicit-cast-on-gitlabcollectionrespons
Feb 3, 2026
Merged

feat: add implicit conversion on gitlabcollectionresponse<T>#1045
louis-z merged 3 commits intomainfrom
feat-add-explicit-cast-on-gitlabcollectionrespons

Conversation

@Toa741
Copy link
Contributor

@Toa741 Toa741 commented Feb 2, 2026

  • With .Net 10 and the new AsyncEnumerable (that was before in System.Linq.Async), it seems that on Linq methods (Where, Select, ...), it might not know which method to take (Select(IEnumerable<>) or Select(IAsyncEnumerable<>)
  • Adding 2 methods to implicitly convert the Collection

While digging a bit:

  • AsEnumerable() exists in System.Linq.Enumerable and should be fully equivalent (no cost, implicit conversion). Might not be needed to add this one explicitely
  • ToAsyncEnumerable() exists in System.Linq.AsyncEnumerable, but is made for converting a IEnumerable to a IAsyncEnumerable (involves additional operations like iterating on the collection)

@Toa741 Toa741 changed the title Feat add explicit cast on gitlabcollectionrespons Feat add implicit cast on gitlabcollectionrespons Feb 2, 2026
@Toa741 Toa741 changed the title Feat add implicit cast on gitlabcollectionrespons Feat add implicit conversion on gitlabcollectionresponse<T> Feb 2, 2026
@Toa741 Toa741 changed the title Feat add implicit conversion on gitlabcollectionresponse<T> feat: add implicit conversion on gitlabcollectionresponse<T> Feb 2, 2026
@Toa741 Toa741 marked this pull request as ready for review February 2, 2026 20:56
@Toa741 Toa741 requested a review from a team as a code owner February 2, 2026 20:56
@Toa741 Toa741 requested review from louis-z and removed request for a team February 2, 2026 20:56
@Toa741 Toa741 changed the title feat: add implicit conversion on gitlabcollectionresponse<T> DRAFT: feat: add implicit conversion on gitlabcollectionresponse<T> Feb 2, 2026
@Toa741 Toa741 changed the title DRAFT: feat: add implicit conversion on gitlabcollectionresponse<T> feat: add implicit conversion on gitlabcollectionresponse<T> Feb 2, 2026
@Toa741 Toa741 marked this pull request as draft February 2, 2026 21:09
@Toa741 Toa741 marked this pull request as ready for review February 2, 2026 21:16
@louis-z louis-z merged commit 3478dae into main Feb 3, 2026
7 checks passed
@louis-z louis-z deleted the feat-add-explicit-cast-on-gitlabcollectionrespons branch February 3, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants