This repository was archived by the owner on Feb 18, 2021. It is now read-only.
Open
Conversation
Contributor
There was a problem hiding this comment.
We either need to communicate to every one to expect declined messages about draining.
Or make a change in the hyperbahn client in all languages to silence the draining error frame log.
Contributor
Author
There was a problem hiding this comment.
Yup, that's a good educational moment to have anyhow, since we'll drain and decline during graceful shutdown anyhow, which we want them to handle.
Plus partial affinity in #66 will Soon ™ drain ex-affinity peers, so clients just really need to get used to this.
Contributor
|
lgtm. May cause hilarity / confusion. |
jcorbin
force-pushed
the
ensure_connected_out_and_drain_in
branch
from
8d2e22d to
20fc2d5
Compare
jcorbin
changed the title
jcorbin
force-pushed
the
ensure_connected_out_and_drain_in
branch
from
20fc2d5 to
45572b6
Compare
jcorbin
force-pushed
the
ensure_connected_out_and_drain_in
branch
2 times, most recently
from
1e86021 to
0de86ea
Compare
jcorbin
force-pushed
the
ensure_connected_out_and_drain_in
branch
from
0de86ea to
3e7d23d
Compare
jcorbin
changed the title
Raynos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Factor out ensurePeerConnected method, and drain the extra incoming connection in it.
r @rf @Raynos