Add support for Search Craft#629
Open
welkinwong wants to merge 1 commit intoua-parser:masterfrom
Open
Conversation
lbarthon
reviewed
Jun 11, 2025
| family_replacement: 'Baidu Explorer' | ||
|
|
||
| # Search Craft | ||
| - regex: '(SearchCraft)/(\d+)\.(\d+)\.(\d+)(?:\.(\d+)|)' |
Member
There was a problem hiding this comment.
can you add a test for the (?:\.(\d+)|) part
welkinwong
force-pushed
the
add-searchcraft-app
branch
from
907d724 to
fdecbd8
Compare
Contributor
Author
|
@lbarthon Thanks for the feedback! I’ve added tests for the major.minor.patch format to ensure compatibility with cases where patch_minor is missing. |
Member
|
sorry for the long delay @welkinwong - I'd like new regexes to be as low as possible in the regexes list |
welkinwong
force-pushed
the
add-searchcraft-app
branch
from
fdecbd8 to
4d1d264
Compare
welkinwong
force-pushed
the
add-searchcraft-app
branch
from
4d1d264 to
d96adb0
Compare
Contributor
Author
|
@lbarthon hi, Thank you for your response. I've gone ahead and updated all the relevant PRs to ensure the regexes are placed as low as possible in the list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Search Craft App