touying-liu:0.1.0

[friskerik]

I am submitting

• a new package
• an update for a package

The package provides a slide template for touying, themed based on official templates for keynote at Linköping University, Sweden.

I have read and followed the submission guidelines and, in particular, I

• selected a name that isn't the most obvious or canonical name for what the package does
• added a typst.toml file with all required keys
• added a README.md with documentation for my package
• have chosen a license and added a LICENSE file or linked one in my README.md
• tested my package locally on my system and it worked
• excluded PDFs or README images, if any, but not the LICENSE

• ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

[elegaanz]

Thank you for the nice template, I have left a few comments :)

[elegaanz]

Is this the case for the background image and the University logo as well? If not, can you please specify who holds copyright for these files and/or under which license they are made available? I would also appreciate if you could double check that you have the right to distribute them. If not, you would have to explain to the users how to obtain them by their own means and import them for use in the template.

[elegaanz]

In general it is recommended to allow passing an image(...) here directly, as it allows users to import their own pictures and use that. Otherwise, they can only use files that you ship with your package. See this section of ours docs for more details.

[elegaanz]

In principle, this package name meets our criteria of what constitutes a distinctive name because of the touying prefix, but the Touying author generally wants each template to add something more than that to make the name actually distinguishable. Can you either add another word to make this template easier to identify, and at the same occasion make it clear that it is not an official university template (which the current name could suggest)? You can also change it entirely to something else to make a pun or reference to some university lore. Feel free to have a look at other package names to get a feel for what is allowed or not. You can also ask me if a potential new name would work before making the change, if you are unsure.

[friskerik]

Thank you for your comments, all very good and relevant. I realized from your comment that I hadn't really ensured the rights for the assets. I have now investigated and there are no problems so I will update accordingly. I will also address the more technical aspects you raised and possibly a new name for the package (including unofficial).

Should this pull-request then be closed and I create a new one with the updates?

Thanks again for your suggestions (and also your work with Typst which I thoroughly enjoy using).

[elegaanz]

Hello, you can push new commits to this pull request branch, no need to create a new one.

[friskerik]

OK, great I'll do that then. I got some (positive) feedback from the university people responsible for the templates, so I'll take care of that also when preparing a new version. I'll get back to you when I'm done.