-
Notifications
You must be signed in to change notification settings - Fork 880
bootstrapicons:0.0.1 #3841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
bootstrapicons:0.0.1 #3841
Conversation
elegaanz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a big fan of shipping all these icons. We try to limit the size of this repository to keep it relatively fast to download the whole package index and work on it locally, and more generally we prefer to limit the size of packages. If the icons are available as an icon font, it would be a better option in my opinion (in which case the user would be responsible for installing the font, you should not ship it with your package). Otherwise, I think we will have to reject this package, at least until we change the way our package index works (which is a long term goal, but not a priority).
Co-authored-by: Ana Gelez <ana+github@gelez.xyz>
|
Thank you very much for the feedback! Unfortunately, the bootstrap icons are only available as svgs and not as a font itself. The motivation behind the package was practical: I repeatedly found myself manually copying Bootstrap SVGs between projects because the set of icons in With your constraints in mind, do you see an alternative path for making a richer icon set broadly available to users? |
|
Hi @elegaanz, thank you again for the comments and motivation to keep things small and efficient. I had a thought about how we can make this package work while keeping its functionality. Here is what I came up with (see also updated files):
This way we reduced the filecount from 2k+ down to 8 (including toml, Readme, License, etc) and total filesize from 4+M down to 1M bytes (all values reported by Thanks, |
I am submitting
Description: Provides a single function
#bsicon("airplane")to display Bootstrap Icons. The package ships all 2000 svg icons (all MIT licensed).I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE