fix: reject nested where clauses on missing fields#1755
Open
LaplaceYoung wants to merge 2 commits intotypicode:mainfrom
Open
fix: reject nested where clauses on missing fields#1755LaplaceYoung wants to merge 2 commits intotypicode:mainfrom
LaplaceYoung wants to merge 2 commits intotypicode:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_wherepredicates with missing or non-object intermediate fields as mismatches when they contain known operators._whereoperators.orclauses, and theGET /posts?_where=...request path.Verification
pnpm exec node --experimental-strip-types --test src/app.test.ts src/matches-where.test.tspnpm testpnpm typecheckpnpm lintpnpm exec oxfmt --check src/app.test.ts src/matches-where.ts src/matches-where.test.tspnpm exec tscstrict []andbypass []git diff --checkpnpm buildreaches the package script and fails on Windows becauserm -rf libis not available in PowerShell.pnpm exec tscwas used to verify the TypeScript build step directly.Fixes #1731