Skip to content

Conversation

@voxik
Copy link
Contributor

@voxik voxik commented Aug 21, 2025

The spec/support/server.rb file does not have executable bit set, therefore the shebang is useless. Other option could be to add the executable bit and store it in repo.

And of course, the last option could be that setting the executable bit explicitly when needed is the right way to go. In that case, please feel free to ignore this PR and sorry for the noise.

The `spec/support/server.rb` file does not have executable bit set,
therefore the shebang is useless.
@tagliala
Copy link
Contributor

tagliala commented Aug 23, 2025

Related to the test server, there is also a

ethon/Rakefile

Lines 30 to 37 in 0e80211

desc "Start up the test servers"
task :start do
require_relative 'spec/support/boot'
begin
Boot.start_servers(:rake)
rescue Exception
end
end

which is not working anymore. Can it be dropped?

@voxik
Copy link
Contributor Author

voxik commented Aug 25, 2025

Can it be dropped?

It likely can. The boot.rb was dropped here and I can't see it would be ever used for something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants