Use alignWith in alignMergeWith

[joroKr21]

alignWith is usually overridden for efficiency

[satorg]

Thank you!
Would you consider adding a new law into cats.laws.AlignLaws along with a corresponding rule in AlingTests please?
Something similar to

cats/laws/src/main/scala/cats/laws/AlignLaws.scala

Lines 45 to 46 in 7a30dc2

	def alignWithConsistent[A, B, C](fa: F[A], fb: F[B], f: A Ior B => C): IsEq[F[C]] =
	fa.alignWith(fb)(f) <-> fa.align(fb).map(f)

[joroKr21]

@satorg that law already exists. Am I missing something?

[satorg]

I mean, a law that would check a correspondence between alignMergeWith and alignWith.
The existing law checks alignWith <-> align.

[joroKr21]

Done, but it seems like now unrelated tests are failing

[danicheg]

Just a nit but maybe these changes to the import style are unnecessary. Although it's Scalafmt duty, we use scala213source3 dialect that allows cross-version syntax constructions to be put together.

[joroKr21]

I guess Scalafmt is not configured to update the imports

[danicheg]

Hmm, we have this
runner.dialectOverride.allowStarWildcardImport = false
and it appears to be not working (or maybe it works oppositely to my expectations)

[satorg]

@danicheg , good catch btw!
I removed that line from .scalafmt.conf and got this: #4677.

[danicheg]

Hah, I thought we'd like to keep the Scala 2 style :) But okay I don't strongly disagree with this.

[satorg]

Hmm... I doesn't exactly compile for all the modules in the repo. I guess, it could be a reason why it was disabled 🤔

[joroKr21]

Reverted. Just keep in mind that if you let Intellij optimize imports it will replace them with star

[danicheg]

IIRC, the import style was configurable there.

[joroKr21]

Perhaps, I didn't check but it takes if from sbt

[satorg]

Thank you!