fix: remove return types for methods without parentheses#24
Merged
yhk1038 merged 1 commit intotype-ruby:mainfrom Dec 28, 2025
Merged
fix: remove return types for methods without parentheses#24yhk1038 merged 1 commit intotype-ruby:mainfrom
yhk1038 merged 1 commit intotype-ruby:mainfrom
Conversation
yhk1038
approved these changes
Dec 28, 2025
Contributor
There was a problem hiding this comment.
Great first contribution! 🎉
The fix looks good - properly handles methods without parentheses by using the existing VISIBILITY_PATTERN and METHOD_NAME_PATTERN constants.
Thanks for including a test case as well!
This will be included in the next patch release.
I'm planning to do it today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #23