Fix bug causing the bodies of all requests to be concatenated #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I added the middleware that checks the response body size in #32, I introduced a bug where the response bodies for all requests in a redirect "chain" gets included in the body returned in the `Twingly::HTTP::Response` object. What I did here was to move the middleware after the FollowRedirects middleware, to ensure we run the middleware on each request, instead of handling all response body chunks at once. The test I added here (along with some other existing tests), would fail with the following error before this fix: 1) Twingly::HTTP::Client#post when given a host that redirects when following redirects only returns the body of the final request Failure/Error: expect(response.fetch(:body)).to eq("finished!") expected: "finished!" got: "redirect...finished!" (compared using ==) Shared Example Group: "common HTTP behaviour for" called from ./spec/lib/twingly/http_spec.rb:554 # ./spec/lib/twingly/http_spec.rb:159:in `block (5 levels) in <top (required)>'
Before this it was registered as a request middleware. I didn't think about that when I added it in #32. This doesn't seem to make any difference, I just thought it makes sense to change this anyway, as this middleware works with the response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I added the middleware that checks the response body size in #32, I introduced a bug where the response bodies for all requests in a redirect "chain" gets included in the body returned in the
Twingly::HTTP::Responseobject.What I did here was to move the middleware after the
FollowRedirectsmiddleware, to ensure we run the middleware on each request, instead of handling all response body chunks at once.The test I added here (along with some other existing tests), would fail with the following error before this fix: