Replace parent-child analogy in doc/tags/extends.rst#4787
Open
llupa wants to merge 1 commit intotwigphp:3.xfrom
Open
Replace parent-child analogy in doc/tags/extends.rst#4787llupa wants to merge 1 commit intotwigphp:3.xfrom
doc/tags/extends.rst#4787llupa wants to merge 1 commit intotwigphp:3.xfrom
Conversation
Contributor
Author
|
This might be a language / cultural thing. But the analogy about filling holes, was ... weird? |
stof
reviewed
Mar 19, 2026
stof
reviewed
Mar 19, 2026
doc/tags/extends.rst
Outdated
| defines the content that fills the hole in the *parent*. If there were two | ||
| similarly-named ``block`` tags in a template, that template's parent wouldn't | ||
| know which one of the blocks' content to use. | ||
| directions. Think of each block as a named puzzle piece: it defines a slot |
Member
There was a problem hiding this comment.
not sure we need this puzzle piece analogy.
Talking about slot instead of hole makes sense though. It will allow people to relate that to their knowledge of HTML shadow root which also uses that naming (it does not work exactly the same, but the idea of defining a place where content will be inserted is related)
Contributor
Author
There was a problem hiding this comment.
I restored the sentence how it was and replaced hole with slot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.