Skip to content

Bump srvx from 0.8.9 to 0.11.13 #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Bump srvx from 0.8.9 to 0.11.13 #816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
be9a7a7
Bump srvx from 0.8.9 to 0.11.13
dependabot[bot] Mar 26, 2026
c036cfe
fix: narrow srvx node handler typing
Copilot Mar 30, 2026
9dff954
test: use real server for preserved request hook
Copilot Mar 30, 2026
2e03b90
test: avoid mock response incompatibility with srvx
Copilot Mar 30, 2026
dc0264d
test: close temporary server in preserved request case
Copilot Mar 30, 2026
ebc738e
test: simplify custom request typing in hook test
Copilot Mar 30, 2026
ae555c6
fix: use srvx node request adapter directly
Copilot Apr 2, 2026
e4a15ff
test: minimize mock shims for srvx node adapter
Copilot Apr 2, 2026
e8af722
test: preserve raw header casing in srvx mock
Copilot Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"debug": "^4.3.4",
"lodash.throttle": "^4.1.1",
"set-cookie-parser": "^2.7.1",
"srvx": "~0.8.9"
"srvx": "~0.11.13"
},
"devDependencies": {
"@types/debug": "^4.1.12",
Expand Down
6 changes: 4 additions & 2 deletions packages/server/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import http from 'node:http'
import {EventEmitter} from 'node:events'

import type {ServerRequest} from 'srvx'
import {toNodeHandler} from 'srvx/node'
import {NodeRequest, sendNodeResponse} from 'srvx/node'
import debug from 'debug'
import {EVENTS, ERRORS, REQUEST_METHODS, TUS_RESUMABLE, HEADERS} from '@tus/utils'
import type {DataStore, Upload, CancellationContext} from '@tus/utils'
Expand Down Expand Up @@ -123,7 +123,9 @@ export class Server extends EventEmitter {
}

async handle(req: http.IncomingMessage, res: http.ServerResponse) {
return toNodeHandler(this.handler.bind(this))(req, res)
const request = new NodeRequest({req, res})
const response = await this.handler(request)
return sendNodeResponse(res, response)
}

async handleWeb(req: Request) {
Expand Down
16 changes: 12 additions & 4 deletions packages/server/src/test/Server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,10 @@ describe('Server', () => {

it('should preserve custom request', (done) => {
const userData = {username: 'admin'}
const requestHeaders = {
'Tus-Resumable': TUS_RESUMABLE,
'Upload-Length': '12345678',
}
const server = new Server({
path: '/test/output',
datastore: new FileStore({directory}),
Expand All @@ -455,16 +459,20 @@ describe('Server', () => {
const req = httpMocks.createRequest({
method: 'POST',
url: server.options.path,
headers: {
'tus-resumable': TUS_RESUMABLE,
'upload-length': '12345678',
},
headers: requestHeaders,
})

// Add custom property like Express middleware would
req.user = userData
const mockReq = req as typeof req & {rawHeaders: string[]}
mockReq.rawHeaders = Object.entries(requestHeaders).flat()

const res = httpMocks.createResponse({req})
const mockRes = res as typeof res & {
off: (...args: unknown[]) => unknown
removeListener: (...args: unknown[]) => unknown
}
mockRes.off = res.removeListener.bind(res)
server.handle(req, res)
})

Expand Down