Fix SLAM parameter passing #631
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewrite SLAM parameters using a
RewrittenYamlobject so that namespaces are applied correctly. This ensures that theslam_toolboxparameters (specificallyscan_topicandmap_name) show the fully-qualified topic names and eliminates the need for manual remaps in theGroupAction.Fixes RPSW-2723.
Type of change
How Has This Been Tested?
Tested in-house on
cpr-april, a Turtlebot4 Lite.To launch SLAM:
ros2 launch turtlebot4_navigation slam.launch.py namespace:=/cpr_aprilVerify parameters:
ros2 dump /cpr_april/slam_toolbox:Checklist