Skip to content

[pull] master from ruby:master #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Nov 27, 2025
Merged

[pull] master from ruby:master #515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78aa8d5
[ruby/json] Test current behavior regarding depth for Coder
etiennebarrie Nov 24, 2025
2f192c7
[ruby/json] Respect Coder depth when generating
etiennebarrie Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/json/generator/generator.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1549,7 +1549,7 @@ static VALUE cState_generate_new(int argc, VALUE *argv, VALUE self)
.buffer = &buffer,
.vstate = Qfalse,
.state = state,
.depth = 0,
.depth = state->depth,
.obj = obj,
.func = generate_json
};
Expand Down
5 changes: 5 additions & 0 deletions test/json/json_coder_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,11 @@ def test_json_coder_string_invalid_encoding
assert_equal 2, calls
end

def test_depth
coder = JSON::Coder.new(object_nl: "\n", array_nl: "\n", space: " ", indent: " ", depth: 1)
assert_equal %({\n "foo": 42\n }), coder.dump(foo: 42)
end

def test_nesting_recovery
coder = JSON::Coder.new
ary = []
Expand Down