fix: debug logging for large/binary output #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpalmer
changed the title
danpalmer
changed the title
danpalmer
changed the title
Contributor
Author
|
Build already failing on Windows, but working on macOS/Ubuntu. Will leave that for a separate change as I'm not familiar with Swift on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #213
This doesn't fully solve it, in that stderr is still persisted for the duration of the subprocess and then decoded as UTF-8 for the return value, but I think that's a much smaller problem in general as stderr is often used for smaller error messages as this was designed to read. I'm happy to push that one off for another day.