[Experimental]alternative for using external dependencies implementation #49

frankois944 · 2024-11-04T17:12:00Z

Based on #47

Using the command line instead of String manipulation
Adding local spm can't be done by command line, so I did it manually
Adding platforms can't be done by command line, so I did it manually
Adding complex package support (like firebase : see tests)
Adding toolsVersion
simplify the swift build command

See the new tests for new features

To be done : change the way the version of a spm is set, the command line has limited possibility.

For VersionRange, it's not possible to have a specific one We need to try/cacth every swift step and print on the ouput the error, it's important for the user All test are passing except local package The local package need to be done

we can now use local path, some manual update has been done all tests are passing

add new test for building and liking Firebase using triple for specify the build target

you can set multiple product from a dependency like Firebase

need to duplicate the code of remote function The exception is not forwarded correctly

check case when the list of packages have a empty string add some comment for the versioning of package

plugin/src/main/kotlin/io/github/ttypic/swiftklib/gradle/task/CompileSwiftTask.kt

plugin/src/main/kotlin/io/github/ttypic/swiftklib/gradle/templates/CreatePackageSwift.kt

update comment in interface

We can now set the toolsVersion from the plugin By default, the command line uses the latest swift version available. By at some cases, it can't work and a specific version need to be set.

frankois944 · 2024-11-06T08:05:48Z

I added the capability to set the toolsversion.
By default, it's the latest swift version.

It needs to be set at Warning Level or it will be considered as a Error.

set a non null default value for toolsVersion in CompileTask

rollback unwanted commit change

moving all command for updating the manifest to CreatePackageSwift

frankois944 · 2024-11-11T09:53:42Z

@IlyaGulya Some feedback?

IlyaGulya · 2024-11-11T13:35:41Z

@frankois944 sorry, quite busy this week. I hope to take a look this weekend

tareksabry1337 · 2024-11-21T04:27:02Z

Anything on this? 👀

frankois944 · 2024-11-22T10:00:59Z

Anything on this? 👀

Still waiting 😶‍🌫️

IlyaGulya

@frankois944
Thanks for the PR!
Sorry for the late response.
Overall, love to see more tests, but I have some concerns about API changes and cli usage approach, so I've left some comments.
Waiting for your response.

IlyaGulya · 2024-11-23T18:48:43Z

.../src/functionalTest/kotlin/io/github/ttypic/swiftklib/gradle/fixture/SwiftKlibTestFixture.kt

+    val _minIos = notNull<String>()
+    val _minMacos = notNull<String>()
+    val _minTvos = notNull<String>()
+    val _minWatchos = notNull<String>()


This is a breaking change in plugin API.
Is it really necessary to store versions as strings?

I change from a Int to a String; it has too much limitation.
For example, we can't use this kind of version macos = "10.15.1", this is possible to set in the Package manifest.

I don't think it's a big deal, as it's just a type of the input to change.

plugin/src/main/kotlin/io/github/ttypic/swiftklib/gradle/SwiftPackageDependency.kt

plugin/src/main/kotlin/io/github/ttypic/swiftklib/gradle/templates/CreatePackageSwift.kt

replace indexOfFirst with contains

move from the CLI to String template toolsVersion is by default in version 5.6 and not the current compiler version The current template has been tested ion 5.6 and could not work in the later/earlier version if specified by the user.

frankois944 · 2024-11-26T09:53:41Z

@IlyaGulya I move to the template
The major issue is the format stuck to a specific swift tool version, I put the default version at 5.9.
If the user set another tools version, the manifest can be broken as the API has been changed.

IlyaGulya · 2024-11-26T17:56:09Z

@frankois944 do you know if swift tools follow semantic versioning?
Can we be sure that breaking changes happen only on major releases?
I think currently that should not be an issue, we can always support new tools version, API surface relevant to this plugin does not seem to be large

frankois944 · 2024-11-26T18:22:05Z

@frankois944 do you know if swift tools follow semantic versioning? Can we be sure that breaking changes happen only on major releases? I think currently that should not be an issue, we can always support new tools version, API surface relevant to this plugin does not seem to be large

The Manifest API depends on the swift version declared in the first line.
I didn't follow API evolution, but I think we will see some warning if we have the need to update the template.
We will need to upgrade the template when this version won't be supported by the compiler.
For now, I guess, this template is enough.

IlyaGulya · 2024-11-27T18:04:59Z

@frankois944 merged
Thank you for the contribution!
I will try to finish this draft this weekend and merge to master (and maybe provide a SNAPSHOT build)

sgozdzik · 2025-01-17T17:46:24Z

@frankois944 merged Thank you for the contribution! I will try to finish this draft this weekend and merge to master (and maybe provide a SNAPSHOT build)

Thanks for good work with library! Any idea when you will have some time to release some snapshot build?

markst and others added 8 commits October 27, 2024 13:34

Add example link to radioplayer-kt.

7df04f0

using command line instead of string manipulation

0a6693c

For VersionRange, it's not possible to have a specific one We need to try/cacth every swift step and print on the ouput the error, it's important for the user All test are passing except local package The local package need to be done

fix local spm

3f7ae02

we can now use local path, some manual update has been done all tests are passing

make the plugin working namespace

b47ec30

add new test for building and liking Firebase using triple for specify the build target

WIP: add multi product usage for a SPM repository

8e39b53

you can set multiple product from a dependency like Firebase

fix test

c96f686

need to duplicate the code of remote function The exception is not forwarded correctly

fix test

f3dcc6a

check case when the list of packages have a empty string add some comment for the versioning of package

Merge branch 'ttypic:main' into external-deps-with-command-line

7101138

frankois944 mentioned this pull request Nov 4, 2024

[Feature] Add ability to specify external dependencies #37

Open

frankois944 commented Nov 5, 2024

View reviewed changes

plugin/src/main/kotlin/io/github/ttypic/swiftklib/gradle/task/CompileSwiftTask.kt Show resolved Hide resolved

frankois944 commented Nov 5, 2024

View reviewed changes

plugin/src/main/kotlin/io/github/ttypic/swiftklib/gradle/templates/CreatePackageSwift.kt Outdated Show resolved Hide resolved

frankois944 added 3 commits November 5, 2024 09:04

update remote parameter name

53cf471

update comment in interface

add more complex case

de4969e

Add tools version parameter

23a5847

We can now set the toolsVersion from the plugin By default, the command line uses the latest swift version available. By at some cases, it can't work and a specific version need to be set.

frankois944 added 4 commits November 6, 2024 09:13

Change ExperimentalSwiftklibApi level

3711eb8

It needs to be set at Warning Level or it will be considered as a Error.

fix build (my bad)

b6427ad

set a non null default value for toolsVersion in CompileTask

rollback bad commit

08941f5

rollback unwanted commit change

cleaning CompileSwiftTask

166468f

moving all command for updating the manifest to CreatePackageSwift

IlyaGulya requested changes Nov 23, 2024

View reviewed changes

frankois944 added 4 commits November 24, 2024 09:15

simplify content check

497bb7a

replace indexOfFirst with contains

remove bad copy/paste

4bf80d3

use none as check if the List is not blank

389eeb4

build the manifest from a template

a6c6ab9

move from the CLI to String template toolsVersion is by default in version 5.6 and not the current compiler version The current template has been tested ion 5.6 and could not work in the later/earlier version if specified by the user.

update tools version default version: 5.9

2d3a724

update tools version default version: 5.9

569e339

IlyaGulya approved these changes Nov 27, 2024

View reviewed changes

IlyaGulya merged commit e21cd68 into ttypic:feature/external-dependencies-single-module-experimental Nov 27, 2024

[Experimental]alternative for using external dependencies implementation #49

[Experimental]alternative for using external dependencies implementation #49

Uh oh!

Conversation

frankois944 commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

frankois944 commented Nov 6, 2024

Uh oh!

frankois944 commented Nov 11, 2024

Uh oh!

IlyaGulya commented Nov 11, 2024

Uh oh!

tareksabry1337 commented Nov 21, 2024

Uh oh!

frankois944 commented Nov 22, 2024

Uh oh!

IlyaGulya left a comment

Choose a reason for hiding this comment

Uh oh!

IlyaGulya Nov 23, 2024

Choose a reason for hiding this comment

Uh oh!

frankois944 Nov 24, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

frankois944 commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IlyaGulya commented Nov 26, 2024

Uh oh!

frankois944 commented Nov 26, 2024

Uh oh!

IlyaGulya commented Nov 27, 2024

Uh oh!

sgozdzik commented Jan 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

frankois944 commented Nov 4, 2024 •

edited

Loading

frankois944 commented Nov 26, 2024 •

edited

Loading