This repository was archived by the owner on Oct 15, 2022. It is now read-only.
feat: close button user do not install on storybook#57
Open
guilhermedinardi wants to merge 1 commit intomainfrom
Open
feat: close button user do not install on storybook#57guilhermedinardi wants to merge 1 commit intomainfrom
guilhermedinardi wants to merge 1 commit intomainfrom
Conversation
Member
|
Could send a print? |
Contributor
Author
Member
|
Good. We need to think about the roles of the buttons. Does it make sense to have two |
Contributor
Author
|
I don't know, maybe yes, because we have two decisions to make |
Member
|
Can we discuss on Slack? I believe that we need only on CTA. |
Contributor
Author
|
Ontem eu comecei a fazer a logica do botão de fechar, porem sempre que eu fiz um botão para fechar algo, eu usava algo tipo: então queria entender o motivo de usar uma logica parecida com a de cima não funcionar. const onCloseUserDoNotWantInstall = (e: any) => {
e.preventDefault();
setUserDoNotWantInstall(e);
if (!userDoNotWantInstall) {
return null;
}
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I added a close UI button in the storybook for implementation in PWA