Skip to content
This repository was archived by the owner on Oct 15, 2022. It is now read-only.

feat: close button user do not install on storybook#57

Open
guilhermedinardi wants to merge 1 commit intomainfrom
add-close-button-user-do-not-install-storybook
Open

feat: close button user do not install on storybook#57
guilhermedinardi wants to merge 1 commit intomainfrom
add-close-button-user-do-not-install-storybook

Conversation

@guilhermedinardi
Copy link
Contributor

I added a close UI button in the storybook for implementation in PWA

@arantespp
Copy link
Member

Could send a print?

@guilhermedinardi
Copy link
Contributor Author

@arantespp
Copy link
Member

Good. We need to think about the roles of the buttons. Does it make sense to have two cta buttons? https://modules.ttoss.dev/docs/core/ui/roles

@guilhermedinardi
Copy link
Contributor Author

I don't know, maybe yes, because we have two decisions to make

@arantespp
Copy link
Member

Can we discuss on Slack? I believe that we need only on CTA.

@guilhermedinardi
Copy link
Contributor Author

Ontem eu comecei a fazer a logica do botão de fechar, porem sempre que eu fiz um botão para fechar algo, eu usava algo tipo: onClick={() => setCloseButton(!button)}

então queria entender o motivo de usar uma logica parecida com a de cima não funcionar.

 const onCloseUserDoNotWantInstall = (e: any) => {
    e.preventDefault();
    setUserDoNotWantInstall(e);
    if (!userDoNotWantInstall) {
      return null;
    }
  };

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants