Skip to content

Add tests for andOp, orOp, xorOp. #7 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ttldtor merged 2 commits into from
Sep 30, 2025
Merged

Add tests for andOp, orOp, xorOp. #7 #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6adaa60
Refactor: replace `constexpr` type declarations with `auto` and inlin…
ttldtor Sep 30, 2025
9d0cd27
Add comprehensive tests for `andOp`, `orOp`, and `xorOp` across multi…
ttldtor Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 12 additions & 22 deletions include/bits/bits.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,14 @@
namespace org::ttldtor::bits {

namespace detail {
template <typename T, typename U>
using Gt = std::conditional_t<sizeof(T) >= sizeof(U), T, U>;

template <typename T, typename...>
struct MaxImpl {
using Type = T;
};

template <typename T, typename U, typename... Ts>
struct MaxImpl<T, U, Ts...> {
using Type = MaxImpl<Gt<T, U>, Ts...>::Type;
using Type = MaxImpl<std::conditional_t<sizeof(T) >= sizeof(U), T, U>, Ts...>::Type;
};
} // namespace detail

Expand Down Expand Up @@ -64,8 +61,7 @@ constexpr ValueType sar(ValueType value, ShiftType shift) noexcept;
template <std::integral ValueType, std::unsigned_integral UnsignedShiftType>
constexpr ValueType leftArithmeticShift(ValueType value, UnsignedShiftType shift) noexcept {
using UnsignedValueType = std::make_unsigned_t<std::remove_cv_t<ValueType>>;
constexpr UnsignedShiftType MAX_VALUE_BITS =
static_cast<UnsignedShiftType>(std::numeric_limits<UnsignedValueType>::digits);
constexpr auto MAX_VALUE_BITS = static_cast<UnsignedShiftType>(std::numeric_limits<UnsignedValueType>::digits);

if (shift < MAX_VALUE_BITS) {
return static_cast<ValueType>(static_cast<UnsignedValueType>(value) << shift);
Expand Down Expand Up @@ -99,9 +95,8 @@ constexpr ValueType leftArithmeticShift(ValueType value, SignedShiftType shift)
}

using UnsignedValueType = std::make_unsigned_t<std::remove_cv_t<ValueType>>;
constexpr UnsignedShiftType MAX_VALUE_BITS =
static_cast<UnsignedShiftType>(std::numeric_limits<UnsignedValueType>::digits);
const UnsignedShiftType unsignedShift = static_cast<UnsignedShiftType>(shift);
constexpr auto MAX_VALUE_BITS = static_cast<UnsignedShiftType>(std::numeric_limits<UnsignedValueType>::digits);
const auto unsignedShift = static_cast<UnsignedShiftType>(shift);

if (unsignedShift < MAX_VALUE_BITS) {
return static_cast<ValueType>(static_cast<UnsignedValueType>(value) << unsignedShift);
Expand Down Expand Up @@ -146,8 +141,7 @@ constexpr ValueType sal(ValueType value, ShiftType shift) noexcept {
template <std::integral ValueType, std::unsigned_integral UnsignedShiftType>
constexpr ValueType rightArithmeticShift(ValueType value, UnsignedShiftType shift) noexcept {
using UnsignedValueType = std::make_unsigned_t<std::remove_cv_t<ValueType>>;
constexpr UnsignedShiftType MAX_VALUE_BITS =
static_cast<UnsignedShiftType>(std::numeric_limits<UnsignedValueType>::digits);
constexpr auto MAX_VALUE_BITS = static_cast<UnsignedShiftType>(std::numeric_limits<UnsignedValueType>::digits);

if (shift < MAX_VALUE_BITS) {
return static_cast<ValueType>(value >> shift);
Expand Down Expand Up @@ -182,9 +176,8 @@ constexpr ValueType rightArithmeticShift(ValueType value, SignedShiftType shift)
}

using UnsignedValueType = std::make_unsigned_t<std::remove_cv_t<ValueType>>;
constexpr UnsignedShiftType MAX_VALUE_BITS =
static_cast<UnsignedShiftType>(std::numeric_limits<UnsignedValueType>::digits);
const UnsignedShiftType unsignedShift = static_cast<UnsignedShiftType>(shift);
constexpr auto MAX_VALUE_BITS = static_cast<UnsignedShiftType>(std::numeric_limits<UnsignedValueType>::digits);
const auto unsignedShift = static_cast<UnsignedShiftType>(shift);

if (unsignedShift < MAX_VALUE_BITS) {
return static_cast<ValueType>(value >> unsignedShift);
Expand Down Expand Up @@ -274,9 +267,8 @@ constexpr ValueType leftLogicalShift(ValueType value, SignedShiftType shift) noe
}

using UnsignedValueType = std::make_unsigned_t<std::remove_cv_t<ValueType>>;
constexpr UnsignedShiftType MAX_VALUE_BITS =
static_cast<UnsignedShiftType>(std::numeric_limits<UnsignedValueType>::digits);
const UnsignedShiftType unsignedShift = static_cast<UnsignedShiftType>(shift);
constexpr auto MAX_VALUE_BITS = static_cast<UnsignedShiftType>(std::numeric_limits<UnsignedValueType>::digits);
const auto unsignedShift = static_cast<UnsignedShiftType>(shift);

if (unsignedShift < MAX_VALUE_BITS) {
return static_cast<ValueType>(static_cast<UnsignedValueType>(value) << unsignedShift);
Expand Down Expand Up @@ -322,8 +314,7 @@ constexpr ValueType shl(ValueType value, ShiftType shift) noexcept {
template <std::integral ValueType, std::unsigned_integral UnsignedShiftType>
constexpr ValueType rightLogicalShift(ValueType value, UnsignedShiftType shift) noexcept {
using UnsignedValueType = std::make_unsigned_t<std::remove_cv_t<ValueType>>;
constexpr UnsignedShiftType MAX_VALUE_BITS =
static_cast<UnsignedShiftType>(std::numeric_limits<UnsignedValueType>::digits);
constexpr auto MAX_VALUE_BITS = static_cast<UnsignedShiftType>(std::numeric_limits<UnsignedValueType>::digits);

if (shift < MAX_VALUE_BITS) {
return static_cast<ValueType>(static_cast<UnsignedValueType>(value) >> shift);
Expand Down Expand Up @@ -358,9 +349,8 @@ constexpr ValueType rightLogicalShift(ValueType value, SignedShiftType shift) no
}

using UnsignedValueType = std::make_unsigned_t<std::remove_cv_t<ValueType>>;
constexpr UnsignedShiftType MAX_VALUE_BITS =
static_cast<UnsignedShiftType>(std::numeric_limits<UnsignedValueType>::digits);
const UnsignedShiftType unsignedShift = static_cast<UnsignedShiftType>(shift);
constexpr auto MAX_VALUE_BITS = static_cast<UnsignedShiftType>(std::numeric_limits<UnsignedValueType>::digits);
const auto unsignedShift = static_cast<UnsignedShiftType>(shift);

if (unsignedShift < MAX_VALUE_BITS) {
return static_cast<ValueType>(static_cast<UnsignedValueType>(value) >> shift);
Expand Down
Loading