Add runtime parsing of colors using flags#66
Open
DogWaterDev wants to merge 4 commits intotsoding:masterfrom
Open
Add runtime parsing of colors using flags#66DogWaterDev wants to merge 4 commits intotsoding:masterfrom
DogWaterDev wants to merge 4 commits intotsoding:masterfrom
Conversation
…ing the --background-color, --pause-color, and --main-color flags, which accept a hexadecimal input (e.g. AAAAAA or 696969).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the background, main, and pause colors were set using three macros each in
src/common.cNow, they are saved in one struct per color under
src/main.c, meaning they can be set at run-time.Usage:
sowon --background-color AABBCC --pause-color CCBBAA --main-color 696969The order does not matter, lower-case and upper-case are supported.
If no valid hex string can be formed from the input, it defaults to black with a warning.
If the color argument is missing, it exits with an error.
This makes it easier to adjust the colors to a certain theme without having to recompile (for example maybe a halloween stream or similar, you might make the colors orange and black) or for other streamers who want to use colors other than the defaults without having to recompile