Fix Unicode UTF-8 does not work in Windows console. #187 #198
+616
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow other processes to read from or delete the same file while we have it currently opened for reading. Allow current process to open file for reading while other processes have this file already opened for reading and are sharing this file for reading.
MarekKnapek
force-pushed
the
187
branch
5 times, most recently
from
99ac627 to
0db3cc9
Compare
Member
Contributor
|
In case this get reopen, i recoment change the defines at lines 159 to 163 as i explained at #202 (comment) |
KillerxDBr
reviewed
Jan 26, 2026
| NOB_ASSERT(narrow_str); | ||
| NOB_ASSERT(narrow_capacity >= 1); | ||
|
|
||
| narrow_len = WideCharToMultiByte(CP_UTF8, 0, wide_str, wide_len, narrow_str, narrow_capacity, NULL, NULL); |
Contributor
There was a problem hiding this comment.
add flags WC_ERR_INVALID_CHARS | WC_NO_BEST_FIT_CHARS and maybe check error (narrow_len == 0)?
KillerxDBr
reviewed
Jan 26, 2026
|
|
||
| NOBDEF bool nob_read_entire_file(const char *path, Nob_String_Builder *sb) | ||
| { | ||
| #ifdef _WIN32 |
Contributor
There was a problem hiding this comment.
wouldn't it be more maintainable to use _wfopen instead of rewritting the entire function? with a small ifdef, just to convert to UTF16 and reuse the rest of the function, making it easier if something change in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.