Skip to content

remove unwrap in pyo3 module #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
molpopgen merged 1 commit into from
May 16, 2025
Merged

remove unwrap in pyo3 module #751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions python/tskit_glue/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,20 +54,16 @@ impl IndividualMetadata {

/// Decode mutation metadata generated in rust via the `bincode` crate.
#[pyfunction]
fn decode_bincode_mutation_metadata(md: Vec<u8>) -> MutationMetadata {
// NOTE: the unwrap here is not correct for production code
// and a failure will crash the Python interpreter!
let md = bincode::deserialize_from(md.as_slice()).unwrap();
md
fn decode_bincode_mutation_metadata(md: Vec<u8>) -> PyResult<MutationMetadata> {
bincode::deserialize_from(md.as_slice())
.map_err(|_| pyo3::exceptions::PyValueError::new_err("error decoding mutation metadata"))
}

/// Decode individual metadata generated in rust via the `bincode` crate.
#[pyfunction]
fn decode_bincode_individual_metadata(md: Vec<u8>) -> IndividualMetadata {
// NOTE: the unwrap here is not correct for production code
// and a failure will crash the Python interpreter!
let md = bincode::deserialize_from(md.as_slice()).unwrap();
md
fn decode_bincode_individual_metadata(md: Vec<u8>) -> PyResult<IndividualMetadata> {
bincode::deserialize_from(md.as_slice())
.map_err(|_| pyo3::exceptions::PyValueError::new_err("error decoding individual metadata"))
}

/// A Python module implemented in Rust.
Expand Down
Loading