fix: add same-net trace junction phase#363
Open
RYB-404 wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29
Summary
SameNetTraceJunctionSolverpipeline phase after trace cleanup.Why this approach
There are already broader attempts for this bounty. This PR keeps the change small and non-destructive: it connects close same-net segments by sharing a concrete point, without deleting traces or changing unrelated solver phases.
Tests
Local verification
npx @biomejs/biome@2.2.2 format --write ...git diff --checkCould not run Bun tests locally because
bunis not installed in this Windows environment.npm install --legacy-peer-deps --no-package-lockalso failed while installingsharpdue to ENOSPC/native build prerequisites, so I left dependency artifacts out of the PR.