feat: merge same-net trace lines close on same X or Y axis#362
Open
Munirubenz wants to merge 1 commit into
Open
feat: merge same-net trace lines close on same X or Y axis#362Munirubenz wants to merge 1 commit into
Munirubenz wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #34
This PR adds a new
mergeSameNetTraceLinesfunction that merges trace line segments that:Changes
lib/solvers/TraceCleanupSolver/mergeSameNetTraceLines.tsTraceCleanupSolver.tsas a final cleanup passHow it works
After all other cleanup steps, traces are grouped by their netId. Segments on the same axis within the threshold distance are merged into a single extended segment.