fix: remove extra net label in repro61 by refining placement logic based on global connectivity#361
Open
pon024587-collab wants to merge 2 commits into
Open
Conversation
…lobal connectivity
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes schematic-trace-solver#79 where redundant net labels were being placed even when components were already physically connected via traces or
directConnections.Changes
NetLabelPlacementSolver.tsto differentiate between "globally connected" pins and "physically connected components" (those connected by traces/direct connections).repro61), the redundant net labels are now skipped.Testing
Created a new test suite
tests/solvers/SchematicTracePipelineSolver/repro61_extra_label.test.tswhich covers:directConnectionexists between pins on the same net.repro01,svg.test.ts) still pass.