Skip to content

Linux support#327

Open
devinprater wants to merge 2 commits intotrypsynth:masterfrom
devinprater:master
Open

Linux support#327
devinprater wants to merge 2 commits intotrypsynth:masterfrom
devinprater:master

Conversation

@devinprater
Copy link

(Hopefully) adds Linux support. It builds and runs on my machine, works with book navigation commands like h, k, 1 through 6, ETC. F10 first time speaks file menu cause Orca doesn't speak it automatically. h and such speak line plus element through Orca.

@trypsynth
Copy link
Owner

Whoa, okay, so how is this different from #197?
Thanks a ton for all the work, I'm just trying to get a clear picture here. Should I combine those two PR's?

@devinprater
Copy link
Author

devinprater commented Feb 11, 2026 via email

@trypsynth
Copy link
Owner

@devinprater thanks for your PR! However, I don't really understand a few parts of this code:

  1. Why introduce this weird accessibility.rs module instead of putting Orca speech into the live-region crate, also on my GitHub? I'd gladly take a PR there :)
  2. What's all this stuff in document_manager.rs? I understand the shift f10 handling, although that does feel a bit like an ugly hack to me, we use shift f10 for something else already, but the big function you added and all the tests for it don't make sense to me. What is this for?
  3. Why did you change how headings are formatted in src/ui/navigation.rs?
  4. Is there a reason you changed the logic for clicking on the tray icon to left down instead of left up? For some reason I think left up is more reliable on windows at least, but I have no idea about other platforms, maybe we can platform gate it?

Once again, thanks for the contribution!

@devinprater
Copy link
Author

devinprater commented Feb 13, 2026 via email

@trypsynth
Copy link
Owner

Yup, figured, this looked a bit vibe coded. That's no problem for me to be clear, but I do review vibe coded PR's just as harshly, if not a bit harsher, than normal PR's. Thanks for your work!

@devinprater
Copy link
Author

devinprater commented Feb 13, 2026 via email

@trypsynth
Copy link
Owner

We now use the latest live region with your Linux changes. Happy hacking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants