Conversation
Linux support: accessibility parity, navigation hotkeys, and build updates
Owner
|
Whoa, okay, so how is this different from #197? |
Author
|
Well, I'm not sure that other one ever worked, from what I remember they
got to a point and then kinda gave up. This one loads files including
epubs, haven't tested pdf and I don't have brain enough for that today, h
and other quick nav keys work, speaks through Orca over dbus messages so no
yucky speech-dispatcher stuff, which ah crap I should do that with fastSM
too, use Orca that is. The text view works and so does menus and dialogs.
Devin Prater
***@***.***
…On Wed, Feb 11, 2026 at 2:35 PM Quin Gillespie ***@***.***> wrote:
*trypsynth* left a comment (trypsynth/paperback#327)
<#327 (comment)>
Whoa, okay, so how is this different from #197
<#197>?
Thanks a ton for all the work, I'm just trying to get a clear picture
here. Should I combine those two PR's?
—
Reply to this email directly, view it on GitHub
<#327 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADUMTTSCDA6JNIJU43PZ5G34LOHBHAVCNFSM6AAAAACUZIV3XOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQOBXGAZDQOBVG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
@devinprater thanks for your PR! However, I don't really understand a few parts of this code:
Once again, thanks for the contribution! |
Author
|
Honestly I just had AI work on it until it worked well enough to open a
book, quick navigation, all that. Some of those changes were probably from
when h for heading either did nothing or didn't speak the line I move to,
so I'll have it clean things up from those changes, and see about getting
that live region support in your live region crate.
Devin Prater
***@***.***
…On Thu, Feb 12, 2026 at 2:03 PM Quin Gillespie ***@***.***> wrote:
*trypsynth* left a comment (trypsynth/paperback#327)
<#327 (comment)>
@devinprater <https://github.com/devinprater> thanks for your PR!
However, I don't really understand a few parts of this code:
1. Why introduce this weird accessibility.rs module instead of putting
Orca speech into the live-region crate, also on my GitHub? I'd gladly take
a PR there :)
2. What's all this stuff in document_manager.rs? I understand the
shift f10 handling, although that does feel a bit like an ugly hack to me,
we use shift f10 for something else already, but the big function you added
and all the tests for it don't make sense to me. What is this for?
3. Why did you change how headings are formatted in
src/ui/navigation.rs?
4. Is there a reason you changed the logic for clicking on the tray
icon to left down instead of left up? For some reason I think left up is
more reliable on windows at least, but I have no idea about other
platforms, maybe we can platform gate it?
Once again, thanks for the contribution!
—
Reply to this email directly, view it on GitHub
<#327 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADUMTTQLFPESDC5TIMSP3DT4LTMCNAVCNFSM6AAAAACUZIV3XOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQOJTGEYTGMZXHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Owner
|
Yup, figured, this looked a bit vibe coded. That's no problem for me to be clear, but I do review vibe coded PR's just as harshly, if not a bit harsher, than normal PR's. Thanks for your work! |
Author
|
Oh I'm glad you do review it. So I believe I've gotten live region stuff
separated out and will pr that next. I had to jigger live region
announcement for the table of contents cause the Linux tree view doesn't
talk, so now it just reads the item you're on using Orca. I haven't seen it
have a collapsed or expanded state... Oh never mind gonna have to wire
collapsed/expanded state in too. This may take a while to get all hammered
and cleaned.
Devin Prater
***@***.***
…On Fri, Feb 13, 2026 at 9:32 AM Quin Gillespie ***@***.***> wrote:
*trypsynth* left a comment (trypsynth/paperback#327)
<#327 (comment)>
Yup, figured, this looked a bit vibe coded. That's no problem for me to be
clear, but I do review vibe coded PR's just as harshly, if not a bit
harsher, than normal PR's. Thanks for your work!
—
Reply to this email directly, view it on GitHub
<#327 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADUMTTUW74WHNFJTUBR4PYT4LXVAXAVCNFSM6AAAAACUZIV3XOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQOJXHA2DCNBXHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Owner
|
We now use the latest live region with your Linux changes. Happy hacking! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Hopefully) adds Linux support. It builds and runs on my machine, works with book navigation commands like h, k, 1 through 6, ETC. F10 first time speaks file menu cause Orca doesn't speak it automatically. h and such speak line plus element through Orca.