Skip to content

Conversation

@bmos
Copy link
Contributor

@bmos bmos commented Jan 18, 2026

What's Changed

  • Refactor session and driver creation to better handle errors
  • Run ruff format to remove whitespace from empty line
  • In tests that don't rely on session fixture, add check for discarded browser context
  • List each test result individually in github actions log
  • Opt-in to Selenium 5 default behavior (upgrading webdriver to match selenium version) in github actions workflow

Why?

Remaining intermittent test failures occur during session object creation

Refactor ensure_valid_session to check fixture usage.
@bmos bmos marked this pull request as draft January 18, 2026 13:29
@github-actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@bmos bmos changed the title Update ensure_valid_session to only run if session is used in test More robut session fixture Jan 18, 2026
@bmos
Copy link
Contributor Author

bmos commented Jan 18, 2026

I'm going to run the tests a bunch of times sequentially on my fork to see if they pass consistently to really make sure I get all the intermittent failure modes.

@bmos bmos closed this Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant