Skip to content

Cookie transfer fix #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lordjabez merged 2 commits into from
Jan 15, 2026
Merged

Cookie transfer fix #173

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dd4a91
attempt fix for tryolabs#142
bmos Dec 18, 2025
4290e3b
Merge branch 'master' into cookie-transfer-fix
bmos Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions requestium/requestium_mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import tldextract
from parsel.selector import Selector, SelectorList
from selenium.common.exceptions import WebDriverException
from selenium.common.exceptions import NoSuchWindowException, WebDriverException
from selenium.webdriver.common.by import By, ByType
from selenium.webdriver.remote.webdriver import WebDriver as RemoteWebDriver
from selenium.webdriver.support import expected_conditions
Expand Down Expand Up @@ -71,7 +71,7 @@ def ensure_add_cookie(self, cookie: dict[str, Any], override_domain: str | None
cookie_domain = cookie["domain"] if cookie["domain"][0] != "." else cookie["domain"][1:]
try:
browser_domain = tldextract.extract(self.current_url).fqdn
except AttributeError:
except (AttributeError, NoSuchWindowException):
browser_domain = ""
if cookie_domain not in browser_domain:
# TODO @joaqo: Check if hardcoding 'http' causes trouble.
Expand Down
Loading