CS-422 [BUG] Employees missing following confluence sync#2896
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
chasprowebdev
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Confidence score: 2/5
- There is a high-confidence, high-severity logic mismatch in
apps/api/src/integration-platform/controllers/sync.controller.ts: using?? trueconflicts with defaults offalsein both the Zod schema and service layer. - This can concretely flip behavior for integrations missing
isDirectorySource(such as Confluence), creating a likely regression in sync handling rather than a minor edge case. - Given the 8/10 severity and 9/10 confidence, this is risky to merge until the fallback behavior is aligned across controller, schema, and service.
- Pay close attention to
apps/api/src/integration-platform/controllers/sync.controller.ts- incorrect defaulting may misclassify source type and alter sync behavior.
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
…uthoritative manifests Companion to the SyncDefinition.isDirectorySource flag added earlier in this PR: - Add `isDirectorySource?: boolean` to the `IntegrationManifest` interface so code-based manifests can advertise themselves as authoritative employee directories with the same vocabulary that dynamic integrations use via `SyncDefinition.isDirectorySource`. - Set `isDirectorySource: true` on the two code-based manifests that actually perform employee sync today: `google-workspace` and `rippling`. Both are customer-trusted directories of who works at the company, and their inline Phase 2 deactivation in `sync.controller.ts` is the correct behavior for them. Why this matters even though the inline GWS/Rippling sync paths don't go through `processEmployees` today: - Consistency: every authoritative directory now declares its role in one obvious place, regardless of code-based vs dynamic. - Documentation: a future reader of the manifest immediately sees "this integration is the source of truth for employment status." - Future-proofing: if the inline GWS/Rippling sync paths are ever consolidated into the generic `processEmployees` pipeline, the flag is already correctly set and the consolidation becomes a one-line change. No behavior change today — purely declarative. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 3.61.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to merge chas/confluence-sync into dev.
It was created by the [Auto Pull Request] action.
Summary by cubic
Fixes CS-422 by gating Phase 2 deactivation behind a new
isDirectorySourceflag (default off). Non-directory tools like Confluence no longer deactivate employees missing from their API; authoritative directories can still offboard.New Features
isDirectorySourcetoSyncDefinitionandIntegrationManifest(defaultfalse).false, runs whentrueand only deactivates absent members in the same email domain.false,true, and cross-domain no-op.Migration
isDirectorySource: truefor directory-of-record providers (Google Workspace, Okta, Entra, JumpCloud, Rippling); code-based manifests forgoogle-workspaceandripplingare already set.falsefor product-scoped tools (Confluence, Slack, Notion, GitHub, Jira).Written for commit 410f378. Summary will update on new commits. Review in cubic