fix(people): address sixth round of cubic review findings

[Marfuen]

Summary

Fixes 5 valid Cubic findings, replied won't-fix on 2 others:

Fixed:

• Propagate archiver errors to output stream (prevents truncated ZIP as apparent success)
• Clamp "Days since" to 0 for future offboard dates (negative value UX bug)
• Disable evidence dropzone while upload is processing (prevents silent ignore)
• Batch vendor attachment queries in getAccessRevocations (N+1 → 1 query)
• Catch P2002 unique constraint race on revocation create (500 → 400)

Won't fix (replied on PR):

• DTO all-or-none evidence validation — already enforced in controller (PR fix(people): address third round of cubic review findings #2891)
• CSV sanitization order — current order is correct (escape first, then check prefix)

Test plan

• Trigger archiver error during export — response should terminate, not return partial ZIP
• Set future offboard date — "Days since" should show 0
• Click dropzone while upload in progress — should be visually disabled
• View vendor revocations for org with many vendors — should load fast (batched)
• Send duplicate revocation request — should get 400, not 500

🤖 Generated with Claude Code

---

Summary by cubic

Fixes offboarding checklist issues to prevent truncated exports, improve evidence upload UX, harden revocation creation, and speed up vendor revocation loading. Supports Linear CS-312 by making employment event evidence collection and review more reliable.

• Bug Fixes
  • Propagate archive errors to the response stream to prevent partial ZIPs.
  • Clamp “Days since” to 0 for future offboard dates.
  • Disable evidence dropzone while an upload is processing.
  • Batch vendor attachment lookups in getAccessRevocations (N+1 → 1 query).
  • Catch Prisma P2002 on revocation create and return 400 instead of 500.

^{Written for commit 83b0d05. Summary will update on new commits. Review in cubic}

[linear]

CS-312

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
app	Building	Preview, Comment	May 21, 2026 3:43pm
comp-framework-editor	Ready	Preview, Comment	May 21, 2026 3:43pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
portal	Skipped		May 21, 2026 3:43pm

[cubic-dev-ai]

No issues found across 4 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}

[claudfuen]

🎉 This PR is included in version 3.60.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀