[comp] Production Deploy#2809
Conversation
- Introduced functions to infer AWS partition and region based on findings. - Updated remediation prompts to include AWS execution context. - Enhanced ARN normalization for AWS and GovCloud. - Added validation for AWS partition configurations. - Implemented tests for AWS partition utilities. - Updated various services and controllers to support AWS partitioning and GovCloud integration.
- Refactored the CloudTestsSection component for better readability by adjusting line breaks and indentation. - Removed redundant imports and organized existing imports for clarity. - Enhanced filtering logic for findings to streamline the code. - Ensured consistent formatting across severity styles and service names for maintainability.
…ntial update logic - Removed unnecessary console log from AwsAccountSettingsBody component. - Simplified the updateCredential function in EmptyStateOnboarding and CloudSetup components by removing redundant logic for awsType, ensuring cleaner state management.
[dev] [tofikwest] feat/support-gov-cloud-aws
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
There was a problem hiding this comment.
2 issues found across 22 files
Confidence score: 4/5
- This PR looks safe to merge overall, with moderate-confidence UI polish issues rather than core functional breakage (both findings are severity 5/10).
- In
apps/app/src/components/integrations/CloudShellSetup.tsx, the disabled state still shows the “Show full script...” control even though expanding has no visible effect, which can confuse users in the integration setup flow. - In
apps/app/src/app/(app)/[orgId]/integrations/[slug]/components/EmptyStateOnboarding.tsx, hardcoded step numbering can show 2/3/4 when Step 1 is omitted, creating inconsistent onboarding guidance for non-AWS providers. - Pay close attention to
apps/app/src/components/integrations/CloudShellSetup.tsxandapps/app/src/app/(app)/[orgId]/integrations/[slug]/components/EmptyStateOnboarding.tsx- disabled-state UX and conditional step numbering should be aligned to avoid user confusion.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/app/src/components/integrations/CloudShellSetup.tsx">
<violation number="1" location="apps/app/src/components/integrations/CloudShellSetup.tsx:89">
P2: When `disabled` is true, the "Show full script..." button still renders but does nothing — clicking it sets `expanded` without any visible effect since the `<pre>` always shows `disabledMessage`. Hide the expand/collapse button when disabled.</violation>
</file>
<file name="apps/app/src/app/(app)/[orgId]/integrations/[slug]/components/EmptyStateOnboarding.tsx">
<violation number="1" location="apps/app/src/app/(app)/[orgId]/integrations/[slug]/components/EmptyStateOnboarding.tsx:622">
P2: Hardcoded step numbers produce a gap (2, 3, 4) when `awsTypeFields` is empty. For non-AWS cloud providers that don't have an `awsType` field, Step 1 is hidden but subsequent steps still display as 2, 3, 4. Consider computing step numbers dynamically based on which sections are visible.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
| <div className="px-3 py-2.5"> | ||
| <pre className="text-[11px] font-mono leading-relaxed text-foreground/70 whitespace-pre-wrap break-all"> | ||
| {expanded ? finalScript : previewLines} | ||
| {disabled ? disabledMessage : expanded ? finalScript : previewLines} |
There was a problem hiding this comment.
P2: When disabled is true, the "Show full script..." button still renders but does nothing — clicking it sets expanded without any visible effect since the <pre> always shows disabledMessage. Hide the expand/collapse button when disabled.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/app/src/components/integrations/CloudShellSetup.tsx, line 89:
<comment>When `disabled` is true, the "Show full script..." button still renders but does nothing — clicking it sets `expanded` without any visible effect since the `<pre>` always shows `disabledMessage`. Hide the expand/collapse button when disabled.</comment>
<file context>
@@ -74,7 +86,7 @@ export function CloudShellSetup({
<div className="px-3 py-2.5">
<pre className="text-[11px] font-mono leading-relaxed text-foreground/70 whitespace-pre-wrap break-all">
- {expanded ? finalScript : previewLines}
+ {disabled ? disabledMessage : expanded ? finalScript : previewLines}
</pre>
{!expanded && (
</file context>
| <div className="p-6 space-y-4"> | ||
| <StepHeader step={1} title="Create IAM Role" /> | ||
| <CloudShellSetup script={provider.setupScript} externalId={orgId} /> | ||
| <StepHeader step={2} title="Create IAM Role" /> |
There was a problem hiding this comment.
P2: Hardcoded step numbers produce a gap (2, 3, 4) when awsTypeFields is empty. For non-AWS cloud providers that don't have an awsType field, Step 1 is hidden but subsequent steps still display as 2, 3, 4. Consider computing step numbers dynamically based on which sections are visible.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/app/src/app/(app)/[orgId]/integrations/[slug]/components/EmptyStateOnboarding.tsx, line 622:
<comment>Hardcoded step numbers produce a gap (2, 3, 4) when `awsTypeFields` is empty. For non-AWS cloud providers that don't have an `awsType` field, Step 1 is hidden but subsequent steps still display as 2, 3, 4. Consider computing step numbers dynamically based on which sections are visible.</comment>
<file context>
@@ -542,25 +596,48 @@ function CloudSetup({
<div className="p-6 space-y-4">
- <StepHeader step={1} title="Create IAM Role" />
- <CloudShellSetup script={provider.setupScript} externalId={orgId} />
+ <StepHeader step={2} title="Create IAM Role" />
+ <CloudShellSetup
+ script={setupScript}
</file context>
Mintlify-Source: dashboard-editor Co-authored-by: mintlify[bot] <109931778+mintlify[bot]@users.noreply.github.com>
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Adds full AWS GovCloud support with partition-aware credentials, ARN handling, and environment-specific CloudShell/remediation scripts. Also documents a People API endpoint to resend portal invites and removes hero images from the docs introduction.
New Features
awsTypein provider metadata; parse account IDs fromarn:(aws|aws-us-gov); normalize partitions in the command executor and default regions in remediation./v1/people/{id}/resend-portal-invitetopackages/docs/openapi.json; removed hero images frompackages/docs/introduction.mdx.Migration
SECURITY_HUB_GOVCLOUD_ROLE_ASSUMER_ARN,SECURITY_HUB_GOVCLOUD_ACCESS_KEY_ID,SECURITY_HUB_GOVCLOUD_SECRET_ACCESS_KEY,SECURITY_HUB_GOVCLOUD_SESSION_TOKEN.awsTypeasawsoraws-us-gov(defaults toawsif omitted).Written for commit 9e37a75. Summary will update on new commits.