Conversation
CS-343 [New Framework] - PIPEDA, CS-333 [New Framework] - CCPA
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 12 files
Confidence score: 4/5
- This PR looks safe to merge with minimal risk; the reported issue is a localized JSX/SVG attribute naming cleanup rather than a functional logic defect.
- The main concern is in
apps/app/src/app/(app)/[orgId]/trust/portal-settings/components/logos.tsx: using kebab-case SVG props likestroke-width/stop-colorcan trigger React invalid DOM property warnings and reduce consistency/maintainability. - Because the issue is limited in scope (single component) and does not indicate a clear runtime break, the overall merge risk stays low.
- Pay close attention to
apps/app/src/app/(app)/[orgId]/trust/portal-settings/components/logos.tsx- update SVG props to camelCase (strokeWidth,stopColor) to avoid JSX/React property warnings.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/app/src/app/(app)/[orgId]/trust/portal-settings/components/logos.tsx">
<violation number="1" location="apps/app/src/app/(app)/[orgId]/trust/portal-settings/components/logos.tsx:962">
P2: Use camelCase SVG prop names in JSX (`strokeWidth`, `stopColor`) instead of kebab-case attributes.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
| d="M2 108.258V3C2 2.44772 2.44772 2 3 2H113C113.552 2 114 2.44772 114 3V108.258C114 108.58 113.845 108.882 113.583 109.07L58.5834 148.581C58.2348 148.831 57.7652 148.831 57.4166 148.581L2.41657 109.07C2.15505 108.882 2 108.58 2 108.258Z" | ||
| fill="white" | ||
| stroke="url(#paint0_linear_92_63)" | ||
| stroke-width="4" |
Contributor
There was a problem hiding this comment.
P2: Use camelCase SVG prop names in JSX (strokeWidth, stopColor) instead of kebab-case attributes.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/app/src/app/(app)/[orgId]/trust/portal-settings/components/logos.tsx, line 962:
<comment>Use camelCase SVG prop names in JSX (`strokeWidth`, `stopColor`) instead of kebab-case attributes.</comment>
<file context>
@@ -945,3 +945,201 @@ export const SOC3InProgress = (props: React.SVGProps<SVGSVGElement>) => (
+ d="M2 108.258V3C2 2.44772 2.44772 2 3 2H113C113.552 2 114 2.44772 114 3V108.258C114 108.58 113.845 108.882 113.583 109.07L58.5834 148.581C58.2348 148.831 57.7652 148.831 57.4166 148.581L2.41657 109.07C2.15505 108.882 2 108.58 2 108.258Z"
+ fill="white"
+ stroke="url(#paint0_linear_92_63)"
+ stroke-width="4"
+ />
+ <path
</file context>
Suggested change
| stroke-width="4" | |
| strokeWidth="4" |
* feat(app): add 'Remove Device' menu on Devices tab * feat(api): define DELETE endpoint to remove single device agent * feat(app): integrate remove-device endpoint on Devices tab * fix(api): set permission to remove-device-agent endpoint * fix(app): use people action hook for agent device removal --------- Co-authored-by: chasprowebdev <chasgarciaprowebdev@gmail.com> Co-authored-by: chasprowebdev <70908289+chasprowebdev@users.noreply.github.com>
…2797) The device agent already enforces 15 minutes across macOS, Linux, and Windows — the seed description still said 5 minutes for macOS. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…kly (#2796) * chore(trigger): change policy acknowledgment digest from daily to weekly Reduces email frequency for policy signature reminders from daily to weekly (Mondays at 14:00 UTC) to avoid notification fatigue. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(trigger): run policy acknowledgment digest on Tuesdays Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(email): use Resend batch API for policy acknowledgment digest Adds a new `send-batch-email` Trigger.dev task that calls `resend.batch.send()` (up to 100 emails per API call) with permissive validation for partial-failure reporting. - New API endpoint `POST /v1/internal/email/send-batch` - New `sendBatchEmailViaApi` helper for app-side Trigger tasks - Digest task now renders HTML upfront, groups by org, and sends one batch request per org instead of one HTTP call per recipient - Unsubscribe headers included per-email in the batch payload Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(email): address batch email edge cases from review - Guard against missing FROM address env vars (throw early instead of sending empty string) - Fix totalSent metric: data.data only contains successes, so don't decrement for permissive-mode errors - Wrap per-recipient render() in try/catch so one bad template doesn't abort the entire digest run - Validate `to` field as email address in batch DTO Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…evant (#2798) Adds a required justification flow when marking evidence tasks as "not relevant" so auditors can review why a task was excluded. Shows a confirmation dialog with a textarea, stores the reason on the task, and displays a banner on the task detail page. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 3.47.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Adds PIPEDA and CCPA as first‑class frameworks, enables owner‑only device removal from the Devices tab, moves the policy acknowledgment digest to a weekly, batched email flow, and requires justification when marking evidence tasks as not relevant. Also updates the device security task seed to require a 15‑minute screen lock across platforms. (Aligns with Linear CS-343 and CS-333.)
New Features
pipeda/ccpabooleans andpipeda_status/ccpa_status; API/portal accept and return these; UI shows new badges and portal toggles with certificate upload/preview.DELETE /v1/devices/:id(204) with owner check and 403/404 handling; Devices tab adds “Remove Device” menu with confirm, optimistic removal, and disabled state for non‑owners.POST /v1/internal/email/send-batchand Triggersend-batch-emailtask using Resend batch API; policy acknowledgment digest pre‑renders HTML, groups by org, sends one batch per org weekly (Tuesdays 14:00 UTC), and includes per‑email unsubscribe headers.Task.notRelevantJustification; bulk status update acceptsnotRelevantJustificationand sets/clears it when moving to/fromnot_relevant; UI adds a justification dialog (and banner on task detail) for evidence tasks and supports bulk/single updates. OpenAPI updated.Migration
prisma migrate deployto apply new columns and enum values.startedstatus; justification is optional and only stored fornot_relevanttasks.Written for commit 2876232. Summary will update on new commits.