Skip to content

[comp] Production Deploy#2787

Merged
Marfuen merged 4 commits intoreleasefrom
main
May 7, 2026
Merged

[comp] Production Deploy#2787
Marfuen merged 4 commits intoreleasefrom
main

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented May 7, 2026

This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.


Summary by cubic

Fixes onboarding tracker accuracy and prevents linkage hangs. Risk totals are set during onboarding, mitigation steps stay hidden until creation completes, and reranker calls now time out after 30s.

  • Bug Fixes
    • Tracker: init risk totals/info; show created/total for vendor/risk creation; hide mitigation steps until creation; set policies flag so the step displays correctly.
    • Reliability: log vendor/risk mitigation fan-out failures; safely strip {{#if}}/{{/if}} markers in policy templates without breaking nested conditionals.

Written for commit d9308be. Summary will update on new commits.

* fix: address cubic review findings on onboarding PR

P1: Add metadata.set('policies', true) after policy fan-out so the
    tracker boolean flag is set.
P1: Log batchTriggerAndWait failures in vendor/risk mitigation fan-outs
    instead of silently ignoring them.
P2: Strip {{#if}}/{{/if}} markers from mixed-content nodes so template
    syntax doesn't leak into rendered policies.
P2: Fix stale onboardingTriggerJobId locking publish button in
    ToDoOverview.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: strip only first marker occurrence to preserve nested conditionals

The global regex flag in stripMarkerText would remove ALL matching
{{#if}}/{{/if}} markers in a subtree, corrupting boundaries of nested
conditional blocks. Removed the g flag so only the first occurrence
(the one that triggered the match) is stripped.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(onboarding): add comprehensive tests for policy template processor

Covers placeholder replacement, inline/multi-node/nested conditionals,
mixed content nodes, edge cases, buildVariables, buildFlags, processTemplate.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(onboarding): treat zero-item steps as complete in tracker

When an org has no vendors or risks, `total > 0 && completed >= total`
evaluates to false, causing those steps to appear stuck forever.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(onboarding): prevent mitigation steps from flashing complete on load

Revert zero-item guard (total === 0 ||) back to (total > 0 &&) — before
totals metadata is set, the default of 0 caused steps to appear complete
then flip back to in-progress once actual totals arrived.

Also add missing risksTotal/risksInfo metadata alongside vendorsTotal
so risk mitigation progress tracks correctly in the UI.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(onboarding): show created/total format for vendor and risk creation steps

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app (staging) Ready Ready Preview, Comment May 7, 2026 2:08pm
comp-framework-editor (staging) Canceled Canceled May 7, 2026 2:08pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
portal (staging) Skipped Skipped May 7, 2026 2:08pm

Request Review

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

* fix: address cubic review findings on onboarding PR

P1: Add metadata.set('policies', true) after policy fan-out so the
    tracker boolean flag is set.
P1: Log batchTriggerAndWait failures in vendor/risk mitigation fan-outs
    instead of silently ignoring them.
P2: Strip {{#if}}/{{/if}} markers from mixed-content nodes so template
    syntax doesn't leak into rendered policies.
P2: Fix stale onboardingTriggerJobId locking publish button in
    ToDoOverview.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: strip only first marker occurrence to preserve nested conditionals

The global regex flag in stripMarkerText would remove ALL matching
{{#if}}/{{/if}} markers in a subtree, corrupting boundaries of nested
conditional blocks. Removed the g flag so only the first occurrence
(the one that triggered the match) is stripped.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(onboarding): add comprehensive tests for policy template processor

Covers placeholder replacement, inline/multi-node/nested conditionals,
mixed content nodes, edge cases, buildVariables, buildFlags, processTemplate.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(onboarding): treat zero-item steps as complete in tracker

When an org has no vendors or risks, `total > 0 && completed >= total`
evaluates to false, causing those steps to appear stuck forever.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(onboarding): prevent mitigation steps from flashing complete on load

Revert zero-item guard (total === 0 ||) back to (total > 0 &&) — before
totals metadata is set, the default of 0 caused steps to appear complete
then flip back to in-progress once actual totals arrived.

Also add missing risksTotal/risksInfo metadata alongside vendorsTotal
so risk mitigation progress tracks correctly in the UI.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(onboarding): show created/total format for vendor and risk creation steps

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(linkage): add 30s timeout to reranker LLM calls

A hung AI Gateway request was blocking the entire linkage step
indefinitely. The fallback in run-linkage.ts already handles rerank
failures gracefully (falls back to cosine ordering).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Mariano <marfuen98@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: address cubic review findings on onboarding PR

P1: Add metadata.set('policies', true) after policy fan-out so the
    tracker boolean flag is set.
P1: Log batchTriggerAndWait failures in vendor/risk mitigation fan-outs
    instead of silently ignoring them.
P2: Strip {{#if}}/{{/if}} markers from mixed-content nodes so template
    syntax doesn't leak into rendered policies.
P2: Fix stale onboardingTriggerJobId locking publish button in
    ToDoOverview.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: strip only first marker occurrence to preserve nested conditionals

The global regex flag in stripMarkerText would remove ALL matching
{{#if}}/{{/if}} markers in a subtree, corrupting boundaries of nested
conditional blocks. Removed the g flag so only the first occurrence
(the one that triggered the match) is stripped.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(onboarding): add comprehensive tests for policy template processor

Covers placeholder replacement, inline/multi-node/nested conditionals,
mixed content nodes, edge cases, buildVariables, buildFlags, processTemplate.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(onboarding): treat zero-item steps as complete in tracker

When an org has no vendors or risks, `total > 0 && completed >= total`
evaluates to false, causing those steps to appear stuck forever.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(onboarding): prevent mitigation steps from flashing complete on load

Revert zero-item guard (total === 0 ||) back to (total > 0 &&) — before
totals metadata is set, the default of 0 caused steps to appear complete
then flip back to in-progress once actual totals arrived.

Also add missing risksTotal/risksInfo metadata alongside vendorsTotal
so risk mitigation progress tracks correctly in the UI.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(onboarding): show created/total format for vendor and risk creation steps

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(linkage): add 30s timeout to reranker LLM calls

A hung AI Gateway request was blocking the entire linkage step
indefinitely. The fallback in run-linkage.ts already handles rerank
failures gracefully (falls back to cosine ordering).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(onboarding): hide mitigation steps until creation is done

Don't render "Assessing Vendors"/"Assessing Risks" steps until their
prerequisite creation step completes. Prevents the step from flashing
as complete before totals metadata arrives.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Mariano <marfuen98@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel vercel Bot temporarily deployed to staging – portal May 7, 2026 14:02 Inactive
@Marfuen Marfuen merged commit d6d4de6 into release May 7, 2026
8 of 10 checks passed
@claudfuen
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.45.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants