Conversation
…nt/framework views (CS-316) * fix(app): bubble up artifact-based progress through control/requirement/framework views (CS-316) Make progress and compliance reflect underlying artifact completion rather than only fully-satisfied controls, and surface documents alongside policies and tasks throughout the framework view. - Add Documents column to per-requirement controls table - Align EvidenceSubmissionInfo with API field name (submittedAt) so the 6-month freshness check actually fires - Compute requirement status from all control statuses, not just satisfied count - Compute requirement compliance % from average of per-control progress (policies + tasks + documents) - Show aggregate framework % across deduplicated artifacts in the framework progress bar - Mirror the framework view on the requirement page: top progress bar, per-control compliance bar, status next to compliance, paginated controls table, narrower description column - Paginate the requirements table with the DS Table built-in pagination (10/25/50/100) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(app): address cubic review on PR #2695 - Tighten getControlProgressPercent task-filter test: the unrelated task is now `todo` so a missing filter would surface as 50% instead of silently passing at 100%. - Per-control Documents column on the requirement page: reuse getRequirementArtifactCounts so document counts honour the same 6-month freshness rule as the status badge and compliance bar (previously any historical submission counted as completed). Policies and tasks counts also flow through the same aggregator for consistency. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(api): bubble up artifact-based progress in framework compliance score Previously computeFrameworkComplianceScore was binary on full-control satisfaction: a control with one in-progress task pulled the framework to 0%. The frameworks list and overview pages consume this score, so they showed Not Started even when most underlying policies/tasks/documents were already done. - Rewrite computeFrameworkComplianceScore to count unique artifacts (policies by id, tasks by id, document types by formType) across the framework and weight each one equally. - Documents only count as completed when their latest submission is within 6 months (matches the freshness rule used elsewhere). - Drop the now-unused hasAnyArtifact / isControlCompleted helpers. - Tests cover empty frameworks, all-complete, partial progress (vs. old 0%), document freshness, and cross-control deduplication. Also stub frameworkInstance.findMany / sOADocument.findFirst so the existing getOverviewScores tests run again. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Mariano <marfuen98@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
|
🎉 This PR is included in version 3.36.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Update framework compliance scoring to reflect artifact-level progress so overview and framework lists no longer show 0% when work is partially done. Documents now require a fresh submission (within 6 months) to count.
computeFrameworkComplianceScoreto count unique artifacts: policies (by id), tasks (by id), and document types (byformType) with equal weight and cross-control dedup.frameworkInstance.findManyandsOADocument.findFirstin specs to restoregetOverviewScorescoverage.Written for commit 33a7b90. Summary will update on new commits. Review in cubic