Skip to content

[dev] [carhartlewis] lewis/comp-framework-fixes#2357

Merged
carhartlewis merged 1 commit intomainfrom
lewis/comp-framework-fixes
Mar 21, 2026
Merged

[dev] [carhartlewis] lewis/comp-framework-fixes#2357
carhartlewis merged 1 commit intomainfrom
lewis/comp-framework-fixes

Conversation

@github-actions
Copy link
Contributor

This is an automated pull request to merge lewis/comp-framework-fixes into dev.
It was created by the [Auto Pull Request] action.

…ditorPolicyTemplate type

- Replaced instances of PolicyTemplateItem and PolicyTemplate with FrameworkEditorPolicyTemplate in the policies page and related components.
- Updated type definitions in PoliciesClientPage and PolicyDetailsClientPage to ensure consistency across the framework editor.
- Enhanced type safety for policy handling in the framework editor.
@vercel
Copy link

vercel bot commented Mar 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
comp-framework-editor Ready Ready Preview, Comment Mar 21, 2026 4:29pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
app Skipped Skipped Mar 21, 2026 4:29pm
portal Skipped Skipped Mar 21, 2026 4:29pm

Request Review

@cursor
Copy link

cursor bot commented Mar 21, 2026

PR Summary

Low Risk
Low risk type-safety refactor in the framework editor policy pages; main potential issue is the stricter policy.content cast to TipTap JSONContent, which could surface runtime shape mismatches.

Overview
Standardizes policy template typing across the framework editor by removing page-local PolicyItem/PolicyTemplate interfaces and switching serverApi/client props/handlers to use the shared FrameworkEditorPolicyTemplate type from @/db.

On the policy detail page, tightens the editor input typing by casting policy.content to JSONContent | JSONContent[] | null when passing it into PolicyEditorClient.

Written by Cursor Bugbot for commit 91f48d3. This will update automatically on new commits. Configure here.

@carhartlewis carhartlewis merged commit eac8a20 into main Mar 21, 2026
9 of 10 checks passed
@carhartlewis carhartlewis deleted the lewis/comp-framework-fixes branch March 21, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant