Skip to content

[comp] Production Deploy#2342

Merged
Marfuen merged 10 commits intoreleasefrom
main
Mar 19, 2026
Merged

[comp] Production Deploy#2342
Marfuen merged 10 commits intoreleasefrom
main

Conversation

@github-actions
Copy link
Contributor

This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.

github-actions bot and others added 10 commits March 19, 2026 14:54
…ages

Findings links from the framework overview now use ?tab=findings query
param so users land on the correct tab. Added Submissions/Findings tabs
to the documents page and removed the auditor-only guard on findings.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
posthog-node imports node:async_hooks at the top level which breaks
Turbopack's module resolution. Dynamic import defers the resolution to
runtime where Node APIs are available.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jspdf's fflate dependency uses a dynamic Worker that Turbopack cannot
resolve during SSR. Lazy-loading the pdf-generator module defers the
import to runtime in the browser.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Same fflate/Worker SSR issue as PolicyHeaderActions — lazy-load
pdf-generator to avoid Turbopack resolution failure.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jspdf's fflate dependency uses a Node Worker that Turbopack cannot
resolve during client component SSR. Move the jsPDF constructor behind
a dynamic import in pdf-generator.ts and add jspdf to
serverExternalPackages in next.config.ts.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The early return for zero findings was hiding the CreateFindingButton,
preventing auditors from creating the first finding for a document.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
SingleTask uses useSearchParams which requires a Suspense boundary
in its parent server component to avoid de-opting to full client-side
rendering.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…inks-from-overview-page-should-go-to-findings

[dev] [Marfuen] mariano/cs-203-bug-findings-links-from-overview-page-should-go-to-findings
@cursor
Copy link

cursor bot commented Mar 19, 2026

PR Summary

Medium Risk
Moderate risk due to a Next.js version bump and switching PDF/analytics dependencies to dynamic imports, which can affect runtime bundling and SSR behavior. UI navigation changes (tabbed findings/submissions) may also alter deep-linking expectations via the new ?tab= param.

Overview
Adds tabbed navigation for evidence documents and tasks, enabling deep-linking to the Findings view via ?tab=findings and updating findings links (e.g. from FindingsOverview) to land on the correct tab.

Improves findings UX on document pages by always rendering the findings section and showing an empty-state with an optional Create Finding action when there are no findings.

Reduces server bundle impact by lazy-loading heavy dependencies: jspdf usage is moved behind async dynamic imports (and PDF helpers become async), posthog-node is dynamically imported, and Next is configured with serverExternalPackages: ['jspdf']; also bumps next to ^16.2.0.

Written by Cursor Bugbot for commit 7954f13. This will update automatically on new commits. Configure here.

@vercel
Copy link

vercel bot commented Mar 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app (staging) Ready Ready Preview, Comment Mar 19, 2026 5:33pm
portal (staging) Ready Ready Preview, Comment Mar 19, 2026 5:33pm

Request Review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@Marfuen Marfuen merged commit df111fe into release Mar 19, 2026
14 checks passed
@claudfuen
Copy link
Contributor

🎉 This PR is included in version 3.10.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants