Skip to content

[comp] Production Deploy#2339

Merged
Marfuen merged 4 commits intoreleasefrom
main
Mar 19, 2026
Merged

[comp] Production Deploy#2339
Marfuen merged 4 commits intoreleasefrom
main

Conversation

@github-actions
Copy link
Contributor

This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.

github-actions bot and others added 2 commits March 19, 2026 13:41
@vercel
Copy link

vercel bot commented Mar 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
comp-api-test Ready Ready Preview, Comment Mar 19, 2026 2:51pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
app (staging) Skipped Skipped Mar 19, 2026 2:51pm
portal (staging) Skipped Skipped Mar 19, 2026 2:51pm

Request Review

@cursor
Copy link

cursor bot commented Mar 19, 2026

PR Summary

Medium Risk
Changes Google Workspace employee sync behavior so previously deactivated members are never automatically reactivated, which can affect user access and org membership state. Includes new test coverage plus minor UI filtering/rendering tweaks with low functional risk.

Overview
Google Workspace employee sync no longer reactivates existing members. When a matching member record already exists, the sync now always skips it and records a clearer reason (Member is deactivated vs Already a member) instead of auto-reactivating deactivated members.

Adds a comprehensive Jest spec (sync-gws.controller.spec.ts) covering import/skip behavior, deactivation scenarios (suspended/removed users, privileged-role safety, domain checks), exclude-mode behavior, response shape, and error counting.

On the app side, updates the People table status filter to support an explicit Pending option and tightens the Active filter to only show active items; task descriptions now render with whiteSpace: 'pre-line' to preserve line breaks.

Written by Cursor Bugbot for commit 826875f. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Co-authored-by: chasprowebdev <chasgarciaprowebdev@gmail.com>
Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>
* fix(integrations): stop GWS sync from reactivating deactivated members

Previously, the Google Workspace employee sync would reactivate any
deactivated member if they were still active in GWS. This caused
manually deactivated users to be re-enabled on every sync. Now
deactivated members are always skipped — admins must reactivate
manually if needed.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(tests): ensure privilege guard tests exercise the role check

The owner/admin/auditor/multi-role tests were using gwUsers: [] which
made deactivationGwDomains empty — tests passed at the domain check
before the role guard was reached. Now each test includes a GWS user
on the same domain and an unprivileged member to prove deactivation
fires for non-privileged roles while privileged members are protected.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel vercel bot temporarily deployed to staging – portal March 19, 2026 14:51 Inactive
@vercel vercel bot temporarily deployed to staging – app March 19, 2026 14:51 Inactive
@Marfuen Marfuen merged commit ce68882 into release Mar 19, 2026
11 checks passed
@claudfuen
Copy link
Contributor

🎉 This PR is included in version 3.10.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants