Skip to content

[comp] Production Deploy #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Marfuen merged 2 commits into from
Mar 12, 2026
Merged

[comp] Production Deploy #2293

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
184e29a
fix(app): prevent integration dialog content from overflowing modal (…
tofikwest Mar 12, 2026
d44cbc1
Merge branch 'release' into main
Marfuen Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions apps/app/src/components/integrations/ConnectIntegrationDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,8 +651,8 @@ export function ConnectIntegrationDialog({
</Button>
)}
{provider?.setupInstructions && (
<div className="text-sm text-muted-foreground bg-muted/50 p-3 rounded-md max-h-32 overflow-y-auto">
<p className="whitespace-pre-wrap text-xs">{provider.setupInstructions}</p>
<div className="text-sm text-muted-foreground bg-muted/50 p-3 rounded-md max-h-32 overflow-y-auto overflow-x-hidden">
<p className="whitespace-pre-wrap text-xs break-words">{provider.setupInstructions}</p>
</div>
)}
{provider?.category === 'Cloud' && (
Expand All @@ -672,7 +672,7 @@ export function ConnectIntegrationDialog({
onChange={(value) => updateCredential(field.id, value)}
/>
{field.helpText && (
<p className="text-xs text-muted-foreground">{field.helpText}</p>
<p className="text-xs text-muted-foreground break-words">{field.helpText}</p>
Copy link

@cursor cursor bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent break-words fix across form renderers

Low Severity

The break-words class was added to field.helpText in renderAuthForm to prevent long text from overflowing, but the identical help text rendering in renderConfigureForm (line 721) was not updated. Both render the same field.helpText content for the same fields, so long help text will still overflow horizontally in the configure view while being correctly wrapped in the auth form view.

Additional Locations (1)
Fix in Cursor Fix in Web

)}
{errors[field.id] && <p className="text-xs text-destructive">{errors[field.id]}</p>}
</div>
Expand Down Expand Up @@ -751,7 +751,7 @@ export function ConnectIntegrationDialog({

return (
<Dialog open={open} onOpenChange={onOpenChange}>
<DialogContent className="max-w-md">
<DialogContent className="max-w-md overflow-hidden">
<DialogHeader>
<DialogTitle className="flex items-center gap-3">
<div className="w-10 h-10 rounded-lg bg-background border border-border flex items-center justify-center overflow-hidden">
Expand All @@ -768,7 +768,7 @@ export function ConnectIntegrationDialog({
<DialogDescription>{getDialogDescription()}</DialogDescription>
</DialogHeader>

<div className="pt-2">
<div className="pt-2 max-h-[60vh] overflow-y-auto">
{isDataLoading ? (
<div className="flex items-center justify-center py-8">
<Loader2 className="h-6 w-6 animate-spin text-muted-foreground" />
Expand Down
Loading